( )⚙ D10214 typing: add assertions to localrepo.py to appease pytype

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10214

typing: add assertions to localrepo.py to appease pytype
ClosedPublic

Authored by mharbison72 on Mar 13 2021, 2:34 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7e08fa9b3d13: typing: add assertions to localrepo.py to appease pytype

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (13 lines)

Diff 26328

mercurial/localrepo.py

shouldtracktags = self.ui.configbool( shouldtracktags = self.ui.configbool(
b'experimental', b'hook-track-tags' b'experimental', b'hook-track-tags'
) )
if desc != b'strip' and shouldtracktags: if desc != b'strip' and shouldtracktags:
oldheads = self.changelog.headrevs() oldheads = self.changelog.headrevs()
def tracktags(tr2): def tracktags(tr2):
repo = reporef() repo = reporef()
assert repo is not None # help pytype
oldfnodes = tagsmod.fnoderevs(repo.ui, repo, oldheads) oldfnodes = tagsmod.fnoderevs(repo.ui, repo, oldheads)
newheads = repo.changelog.headrevs() newheads = repo.changelog.headrevs()
newfnodes = tagsmod.fnoderevs(repo.ui, repo, newheads) newfnodes = tagsmod.fnoderevs(repo.ui, repo, newheads)
# notes: we compare lists here. # notes: we compare lists here.
# As we do it only once buiding set would not be cheaper # As we do it only once buiding set would not be cheaper
changes = tagsmod.difftags(repo.ui, repo, oldfnodes, newfnodes) changes = tagsmod.difftags(repo.ui, repo, oldfnodes, newfnodes)
if changes: if changes:
tr2.hookargs[b'tag_moved'] = b'1' tr2.hookargs[b'tag_moved'] = b'1'
# #
# Fixing this limitation of the transaction is also needed to track # Fixing this limitation of the transaction is also needed to track
# other families of changes (bookmarks, phases, obsolescence). # other families of changes (bookmarks, phases, obsolescence).
# #
# This will have to be fixed before we remove the experimental # This will have to be fixed before we remove the experimental
# gating. # gating.
tracktags(tr2) tracktags(tr2)
repo = reporef() repo = reporef()
assert repo is not None # help pytype
singleheadopt = (b'experimental', b'single-head-per-branch') singleheadopt = (b'experimental', b'single-head-per-branch')
singlehead = repo.ui.configbool(*singleheadopt) singlehead = repo.ui.configbool(*singleheadopt)
if singlehead: if singlehead:
singleheadsub = repo.ui.configsuboptions(*singleheadopt)[1] singleheadsub = repo.ui.configsuboptions(*singleheadopt)[1]
accountclosed = singleheadsub.get( accountclosed = singleheadsub.get(
b"account-closed-heads", False b"account-closed-heads", False
) )
# Don't reference tr2 in hook() so we don't hold a reference. # Don't reference tr2 in hook() so we don't hold a reference.
# This reduces memory consumption when there are multiple # This reduces memory consumption when there are multiple
# transactions per lock. This can likely go away if issue5045 # transactions per lock. This can likely go away if issue5045
# fixes the function accumulation. # fixes the function accumulation.
hookargs = tr2.hookargs hookargs = tr2.hookargs
def hookfunc(unused_success): def hookfunc(unused_success):
repo = reporef() repo = reporef()
assert repo is not None # help pytype
if hook.hashook(repo.ui, b'txnclose-bookmark'): if hook.hashook(repo.ui, b'txnclose-bookmark'):
bmchanges = sorted(tr.changes[b'bookmarks'].items()) bmchanges = sorted(tr.changes[b'bookmarks'].items())
for name, (old, new) in bmchanges: for name, (old, new) in bmchanges:
args = tr.hookargs.copy() args = tr.hookargs.copy()
args.update(bookmarks.preparehookargs(name, old, new)) args.update(bookmarks.preparehookargs(name, old, new))
repo.hook( repo.hook(
b'txnclose-bookmark', b'txnclose-bookmark',
throw=False, throw=False,
throw=False, throw=False,
**pycompat.strkwargs(args) **pycompat.strkwargs(args)
) )
repo.hook( repo.hook(
b'txnclose', throw=False, **pycompat.strkwargs(hookargs) b'txnclose', throw=False, **pycompat.strkwargs(hookargs)
) )
reporef()._afterlock(hookfunc) repo = reporef()
assert repo is not None # help pytype
repo._afterlock(hookfunc)
tr.addfinalize(b'txnclose-hook', txnclosehook) tr.addfinalize(b'txnclose-hook', txnclosehook)
# Include a leading "-" to make it happen before the transaction summary # Include a leading "-" to make it happen before the transaction summary
# reports registered via scmutil.registersummarycallback() whose names # reports registered via scmutil.registersummarycallback() whose names
# are 00-txnreport etc. That way, the caches will be warm when the # are 00-txnreport etc. That way, the caches will be warm when the
# callbacks run. # callbacks run.
tr.addpostclose(b'-warm-cache', self._buildcacheupdater(tr)) tr.addpostclose(b'-warm-cache', self._buildcacheupdater(tr))
def txnaborthook(tr2): def txnaborthook(tr2):
"""To be run if transaction is aborted""" """To be run if transaction is aborted"""
reporef().hook( repo = reporef()
assert repo is not None # help pytype
repo.hook(
b'txnabort', throw=False, **pycompat.strkwargs(tr2.hookargs) b'txnabort', throw=False, **pycompat.strkwargs(tr2.hookargs)
) )
tr.addabort(b'txnabort-hook', txnaborthook) tr.addabort(b'txnabort-hook', txnaborthook)
# avoid eager cache invalidation. in-memory data should be identical # avoid eager cache invalidation. in-memory data should be identical
# to stored data if transaction has no error. # to stored data if transaction has no error.
tr.addpostclose(b'refresh-filecachestats', self._refreshfilecachestats) tr.addpostclose(b'refresh-filecachestats', self._refreshfilecachestats)
self._transref = weakref.ref(tr) self._transref = weakref.ref(tr)
this logic. For this purpose, the created transaction is passed to the this logic. For this purpose, the created transaction is passed to the
method. method.
""" """
# we must avoid cyclic reference between repo and transaction. # we must avoid cyclic reference between repo and transaction.
reporef = weakref.ref(self) reporef = weakref.ref(self)
def updater(tr): def updater(tr):
repo = reporef() repo = reporef()
assert repo is not None # help pytype
repo.updatecaches(tr) repo.updatecaches(tr)
return updater return updater
@unfilteredmethod @unfilteredmethod
def updatecaches(self, tr=None, full=False): def updatecaches(self, tr=None, full=False):
"""warm appropriate caches """warm appropriate caches