Page MenuHomePhabricator

rust-status: fix issue6456 for the Rust implementation also
ClosedPublic

Authored by Alphare on Mar 15 2021, 10:06 AM.

Details

Summary

This implementation is being used by a few people now, so we need it fixed, even
though a big rewrite will be coming quite soon.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 15 2021, 10:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
rust/hg-core/src/utils/files.rs
206

Clippy pointed out that this will never be true :) I suppose the left left value should also be 0120000, but I'll let you decide if it's worth fixing it (given the comment above)

Alphare added inline comments.Oct 1 2021, 12:09 PM
rust/hg-core/src/utils/files.rs
206

Ha, indeed. Well, this does not need to exist anymore since it isn't used since D11516, it appears this slipped through the "dead code" pass.

martinvonz added inline comments.Oct 1 2021, 12:14 PM
rust/hg-core/src/utils/files.rs
206

Hmm, I suppose the problem is actually that the numbers are meant to be octal (e.g. 0o120000, I think). Doesn't matter if it's going away anyway.

Alphare added inline comments.Oct 1 2021, 12:17 PM
rust/hg-core/src/utils/files.rs
206

See D11549