This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	marmoute	D10265 path: error out if the `path://` reference point to an unknown path
Closed	marmoute	D10264 path: forbid chaining `path://` definitions
Closed	marmoute	D10263 path: introduce a `path://` syntax to reference other path name
Closed	marmoute	D10262 path: extract sub-option logic into its own method
Closed	marmoute	D10261 path: extract the path validation logic into its own submethod
Closed	marmoute	D10260 path: move handling of "default" (*) suboptions value inside __init__

Diff 26571

	sub_opts.update(suboptions)			sub_opts.update(suboptions)
	self._all_sub_opts = sub_opts.copy()			self._all_sub_opts = sub_opts.copy()

	self._apply_suboptions(ui, sub_opts)			self._apply_suboptions(ui, sub_opts)

	def chain_path(self, ui, paths):			def chain_path(self, ui, paths):
	if self.url.scheme == b'path':			if self.url.scheme == b'path':
	assert self.url.path is None			assert self.url.path is None
				try:
	subpath = paths[self.url.host]			subpath = paths[self.url.host]
				except KeyError:
				m = _('cannot use `%s`, "%s" is not a known path')
				m %= (self.rawloc, self.url.host)
				raise error.Abort(m)
	if subpath.raw_url.scheme == b'path':			if subpath.raw_url.scheme == b'path':
	m = _('cannot use `%s`, "%s" is also define as a `path://`')			m = _('cannot use `%s`, "%s" is also define as a `path://`')
	m %= (self.rawloc, self.url.host)			m %= (self.rawloc, self.url.host)
	raise error.Abort(m)			raise error.Abort(m)
	self.url = subpath.url			self.url = subpath.url
	self.rawloc = subpath.rawloc			self.rawloc = subpath.rawloc
	self.loc = subpath.loc			self.loc = subpath.loc
	if self.branch is None:			if self.branch is None:

	$ hg id			$ hg id
	000000000000			000000000000
	$ hg path			$ hg path
	abort: cannot use `path://other_default`, "other_default" is also define as a `path://`			abort: cannot use `path://other_default`, "other_default" is also define as a `path://`
	[255]			[255]
	$ hg pull chain_path			$ hg pull chain_path
	abort: cannot use `path://other_default`, "other_default" is also define as a `path://`			abort: cannot use `path://other_default`, "other_default" is also define as a `path://`
	[255]			[255]

				Test basic error cases
				----------------------

				$ cat << EOF > .hg/hgrc
				> [paths]
				> error-missing=path://unknown
				> EOF
				$ hg path
				abort: cannot use `path://unknown`, "unknown" is not a known path
				[255]
				$ hg pull error-missing
				abort: cannot use `path://unknown`, "unknown" is not a known path
				[255]