( )⚙ D10314 store: drop the `filefilter` argument to `_walk`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10314

store: drop the `filefilter` argument to `_walk`
ClosedPublic

Authored by marmoute on Apr 6 2021, 4:39 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6afb5ef1e776: store: drop the `filefilter` argument to `_walk`
Summary

No code use it anywhere. Dropping it will help replacing the function with
something with a more precise semantic.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 6 2021, 4:39 AM
pulkit accepted this revision.Apr 8 2021, 3:03 AM
This revision is now accepted and ready to land.Apr 8 2021, 3:03 AM
marmoute added a commit: rHG6afb5ef1e776: store: drop the `filefilter` argument to `_walk`.Apr 8 2021, 6:56 AM
Closed by commit rHG6afb5ef1e776: store: drop the `filefilter` argument to `_walk` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 26700.Apr 8 2021, 7:02 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/store.py (4 lines)

Diff 26662

mercurial/store.py

vfs.createmode = self.createmode vfs.createmode = self.createmode
self.rawvfs = vfs self.rawvfs = vfs
self.vfs = vfsmod.filtervfs(vfs, encodedir) self.vfs = vfsmod.filtervfs(vfs, encodedir)
self.opener = self.vfs self.opener = self.vfs
def join(self, f): def join(self, f):
return self.path + b'/' + encodedir(f) return self.path + b'/' + encodedir(f)
def _walk(self, relpath, recurse, filefilter=isrevlog): def _walk(self, relpath, recurse):
'''yields (unencoded, encoded, size)''' '''yields (unencoded, encoded, size)'''
path = self.path path = self.path
if relpath: if relpath:
path += b'/' + relpath path += b'/' + relpath
striplen = len(self.path) + 1 striplen = len(self.path) + 1
l = [] l = []
if self.rawvfs.isdir(path): if self.rawvfs.isdir(path):
visit = [path] visit = [path]
readdir = self.rawvfs.readdir readdir = self.rawvfs.readdir
while visit: while visit:
p = visit.pop() p = visit.pop()
for f, kind, st in readdir(p, stat=True): for f, kind, st in readdir(p, stat=True):
fp = p + b'/' + f fp = p + b'/' + f
if filefilter(f, kind, st): if isrevlog(f, kind, st):
n = util.pconvert(fp[striplen:]) n = util.pconvert(fp[striplen:])
l.append((decodedir(n), n, st.st_size)) l.append((decodedir(n), n, st.st_size))
elif kind == stat.S_IFDIR and recurse: elif kind == stat.S_IFDIR and recurse:
visit.append(fp) visit.append(fp)
l.sort() l.sort()
return l return l
def changelog(self, trypending, concurrencychecker=None): def changelog(self, trypending, concurrencychecker=None):