This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10317

upgrade: do not hardcore file extension of revlogs
ClosedPublic

Authored by marmoute on Apr 6 2021, 4:39 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1c52d77d7861: upgrade: do not hardcore file extension of revlogs
Summary

This logic already lives inside the store module. So lets reuse it instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 6 2021, 4:39 AM
baymax retitled this revision from upgrade: do not hardcore revlog extension to upgrade: do not hardcore file extension of revlogs.Apr 6 2021, 5:22 AM
baymax updated this revision to Diff 26666.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Apr 8 2021, 6:22 AM
baymax updated this revision to Diff 26703.Apr 8 2021, 7:02 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 26706.Apr 8 2021, 10:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 8 2021, 12:54 PM
This revision is now accepted and ready to land.Apr 8 2021, 12:54 PM
baymax updated this revision to Diff 26735.Apr 8 2021, 7:54 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 11 2021, 5:25 PM
marmoute added a commit: rHG1c52d77d7861: upgrade: do not hardcore file extension of revlogs.Apr 11 2021, 7:24 PM
Closed by commit rHG1c52d77d7861: upgrade: do not hardcore file extension of revlogs (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/engine.py (2 lines)

Diff 26809

mercurial/upgrade_utils/engine.py

) )
def _files_to_copy_post_revlog_clone(srcrepo): def _files_to_copy_post_revlog_clone(srcrepo):
"""yields files which should be copied to destination after revlogs """yields files which should be copied to destination after revlogs
are cloned""" are cloned"""
for path, kind, st in sorted(srcrepo.store.vfs.readdir(b'', stat=True)): for path, kind, st in sorted(srcrepo.store.vfs.readdir(b'', stat=True)):
# don't copy revlogs as they are already cloned # don't copy revlogs as they are already cloned
if path.endswith((b'.i', b'.d', b'.n', b'.nd')): if store.revlog_type(path) is not None:
continue continue
# Skip transaction related files. # Skip transaction related files.
if path.startswith(b'undo'): if path.startswith(b'undo'):
continue continue
# Only copy regular files. # Only copy regular files.
if kind != stat.S_IFREG: if kind != stat.S_IFREG:
continue continue
# Skip other skipped files. # Skip other skipped files.