This is an archive of the discontinued Mercurial Phabricator instance.

store: also return some information about the type of file `walk` found
ClosedPublic

Authored by marmoute on Apr 6 2021, 4:39 AM.

Details

Summary

We start returning of 4th information in the store.walk return tuple: the type of the file. This will make it easier for caller to determine which kind of file they are looking at. This should especically help with the upgrade-repo code that has to do a lot of fragile index's file name comparison.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 6 2021, 4:39 AM
pulkit added a subscriber: pulkit.Apr 8 2021, 3:04 AM
pulkit added inline comments.
mercurial/store.py
1

hm, unrelated change?

marmoute planned changes to this revision.Apr 8 2021, 6:03 AM
marmoute added inline comments.
mercurial/store.py
1

No! No! I totally intended to add , f), f) at the end of this docstring.

(hum, update coming)

baymax updated this revision to Diff 26701.Apr 8 2021, 7:02 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 26704.Apr 8 2021, 10:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 8 2021, 12:52 PM

I have needed this in past. Thanks!

This revision is now accepted and ready to land.Apr 8 2021, 12:52 PM
marmoute updated this revision to Diff 26727.Apr 8 2021, 6:57 PM
baymax updated this revision to Diff 26733.Apr 8 2021, 7:54 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 11 2021, 5:25 PM