Page MenuHomePhabricator

fold: start using formatter to print output
ClosedPublic

Authored by pulkit on Oct 12 2017, 5:59 PM.

Details

Reviewers
quark
durham
Group Reviewers
Restricted Project
Commits
rFBHGX2b1e066479ba: fold: start using formatter to print output
Summary

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 12 2017, 5:59 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2017, 5:59 PM
quark requested changes to this revision.Oct 16 2017, 6:24 PM
quark added a subscriber: quark.

Could you use with fm? That will ensure fm.end() gets called.

You can also modernize the code so lock and transaction are in a same with:

with repo.wlock(), repo.lock(), repo.transaction('fold') as tr, ui.formatter(...) as fm:
This revision now requires changes to proceed.Oct 16 2017, 6:24 PM
pulkit updated this revision to Diff 2960.Oct 17 2017, 8:14 PM
pulkit updated this revision to Diff 3139.Oct 27 2017, 6:04 PM
durham accepted this revision.Oct 31 2017, 1:03 PM
This revision was automatically updated to reflect the committed changes.