This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1046

tweakdefaults: enable rebase
AbandonedPublic

Authored by quark on Oct 13 2017, 2:02 AM.

Details

Reviewers
ryanmce
durin42
Group Reviewers
hg-reviewers
Summary

Rebase could be a frequently used command and concept. Therefore enabled.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 13 2017, 2:02 AM
ryanmce accepted this revision as: ryanmce.Oct 13 2017, 1:41 PM
ryanmce added a subscriber: ryanmce.

Accepting as myself (not as a reviewer though, since we're both FB). I'm a big +1 on this.

durin42 added a subscriber: durin42.Oct 13 2017, 3:36 PM

Until we've got a plan for obsolete markers on by default (even if without marker exchange), I think I'd rather hold off on this.

durin42 requested changes to this revision.Oct 13 2017, 3:42 PM

Actually, beyond that: if something is safe enough to be in tweakdefaults and it's not a BC change, it should *be on by default*. As such, turning on a command like rebase is IMO out of scope for tweakdefaults, and you should instead be having the discussion about what it takes to make rebase (and histedit) on by default.

This revision now requires changes to proceed.Oct 13 2017, 3:42 PM
quark abandoned this revision.Oct 13 2017, 3:45 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (4 lines)

Diff 2653

mercurial/ui.py

[ui] [ui]
# The rollback command is dangerous. As a rule, don't use it. # The rollback command is dangerous. As a rule, don't use it.
rollback = False rollback = False
[commands] [commands]
# Make `hg status` emit cwd-relative paths by default. # Make `hg status` emit cwd-relative paths by default.
status.relative = yes status.relative = yes
[extensions]
# Make `rebase` available.
rebase =
[diff] [diff]
git = 1 git = 1
""" """
samplehgrcs = { samplehgrcs = {
'user': 'user':
b"""# example user config (see 'hg help config' for more info) b"""# example user config (see 'hg help config' for more info)
[ui] [ui]