This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10462

heptapod-ci: enable pytype checking
ClosedPublic

Authored by mharbison72 on Apr 18 2021, 1:36 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe917fa36fb58: heptapod-ci: enable pytype checking
Summary

The trigger is manual for now, until we get a better idea about stability,
resource usage, etc.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 18 2021, 1:36 AM
Alphare added a subscriber: Alphare.Apr 19 2021, 10:05 AM

Do you need help fixing the base CI image to get the right Python version?

marmoute added a subscriber: marmoute.Apr 20 2021, 5:48 AM

The ci image is defined in this repository : https://foss.heptapod.net/octobus/ci-dockerfiles/

Docker file for the Mercurial CI is here: ci-mercurial-core/Dockerfile

contrib/heptapod-ci.yml
121

I would recommand starting with adding when: manual to this so that we can double check the impact and runtime before adding it to the default slow.

mharbison72 added a comment.Apr 20 2021, 8:54 AM
In D10462#159008, @Alphare wrote:

Do you need help fixing the base CI image to get the right Python version?

Probably. I know it’s just a matter of adding the right package reference to the Dockerfile, but what builds the image and puts it into the registry? A simple push?

mharbison72 added inline comments.Apr 20 2021, 9:48 AM
contrib/heptapod-ci.yml
121

Will do. Hopefully it can be changed to automatic on stable. For reference, it looks like it's slightly more expensive than a py2 test run: https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/20813

baymax edited the summary of this revision. (Show Details)Apr 20 2021, 3:38 PM
baymax updated this revision to Diff 27151.

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Alphare accepted this revision.Apr 21 2021, 8:27 AM
This revision is now accepted and ready to land.Apr 21 2021, 8:27 AM
mharbison72 added a comment.May 3 2021, 1:31 PM

Now that the CI images are updated, I think this is ready to land.

pulkit accepted this revision.May 6 2021, 3:06 PM
mharbison72 added a commit: rHGe917fa36fb58: heptapod-ci: enable pytype checking.May 14 2021, 3:09 PM
Closed by commit rHGe917fa36fb58: heptapod-ci: enable pytype checking (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/heptapod-ci.yml (14 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 27027

contrib/heptapod-ci.yml

TEST_HGMODULEPOLICY: "c" TEST_HGMODULEPOLICY: "c"
test-py3-chg: test-py3-chg:
<<: *runtests <<: *runtests
variables: variables:
PYTHON: python3 PYTHON: python3
RUNTEST_ARGS: "--blacklist /tmp/check-tests.txt --chg" RUNTEST_ARGS: "--blacklist /tmp/check-tests.txt --chg"
TEST_HGMODULEPOLICY: "c" TEST_HGMODULEPOLICY: "c"
check-pytype-py3:
marmouteUnsubmitted
Not Done

I would recommand starting with adding when: manual to this so that we can double check the impact and runtime before adding it to the default slow.

marmoute: I would recommand starting with adding `when: manual` to this so that we can double check the…
mharbison72AuthorUnsubmitted
Done

Will do. Hopefully it can be changed to automatic on stable. For reference, it looks like it's slightly more expensive than a py2 test run: https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/20813

mharbison72: Will do. Hopefully it can be changed to automatic on stable. For reference, it looks like…
extends: .runtests_template
before_script:
- hg clone . /tmp/mercurial-ci/ --noupdate --config phases.publish=no
- hg -R /tmp/mercurial-ci/ update `hg log --rev '.' --template '{node}'`
- cd /tmp/mercurial-ci/
- make local PYTHON=$PYTHON
- $PYTHON -m pip install --user -U pytype==2021.04.09 cffi
variables:
RUNTEST_ARGS: " --allow-slow-tests tests/test-check-pytype.t"
PYTHON: python3
TEST_HGMODULEPOLICY: "c"
TEST_HGTESTS_ALLOW_NETIO: "1"

tests/test-check-pytype.t

mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error] mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error]
TODO: use --no-cache on test server? Caching the files locally helps during TODO: use --no-cache on test server? Caching the files locally helps during
development, but may be a hinderance for CI testing. development, but may be a hinderance for CI testing.
$ pytype -V 3.6 --keep-going --jobs auto mercurial \ $ pytype -V `"$PYTHON" -c 'import sys; print("%s.%s" % (sys.version_info[0], sys.version_info[1]))'` --keep-going --jobs auto mercurial \
> -x mercurial/bundlerepo.py \ > -x mercurial/bundlerepo.py \
> -x mercurial/changegroup.py \ > -x mercurial/changegroup.py \
> -x mercurial/chgserver.py \ > -x mercurial/chgserver.py \
> -x mercurial/cmdutil.py \ > -x mercurial/cmdutil.py \
> -x mercurial/context.py \ > -x mercurial/context.py \
> -x mercurial/copies.py \ > -x mercurial/copies.py \
> -x mercurial/crecord.py \ > -x mercurial/crecord.py \
> -x mercurial/debugcommands.py \ > -x mercurial/debugcommands.py \