This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10470

chg: pass --no-profile to disable profiling when starting hg serve
ClosedPublic

Authored by spectral on Apr 19 2021, 6:32 PM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8fcc0a829f3d: chg: pass --no-profile to disable profiling when starting hg serve
rHG8138092f8790: chg: pass --no-profile to disable profiling when starting hg serve
Summary

If profiling is enabled via global/user config (as far as I can tell, this
doesn't affect use of the --profile flag, but it probably does affect --config
profiling.enabled=1), then the profiling data can be *cumulative* for the
lifetime of the chg process.

This leads to some "interesting" results where hg claims the walltime is
something like 200s on a command that took only a second or two to run. Worse,
however, is that with at least some profilers (such as the default "stat"
profiler), this can cause a large slowdown while generating the profiler output.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Apr 19 2021, 6:32 PM
marmoute accepted this revision.Apr 20 2021, 6:08 AM
pulkit accepted this revision.Apr 28 2021, 6:40 AM
This revision is now accepted and ready to land.Apr 28 2021, 6:40 AM
spectral added a comment.Apr 30 2021, 7:22 PM
In D10470#160272, @Alphare wrote:

This breaks the CI https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/21383.
Could you send a followup please?

Done in D10537, sorry about that, I clearly forgot to run the whole test suite with --chg. Again. :(

I also sent D10538 so that I could have caught the clang-format issue, and fixed my black installation (it was broken by my distro upgrading to py3.9), which triggered D10539.

Revision Contents
Changeset List

PathPackages
Mcontrib/chg/chg.c (1 line)
Mtests/test-chg.t (2 lines)

Diff 27253

contrib/chg/chg.c

static void execcmdserver(const struct cmdserveropts *opts) static void execcmdserver(const struct cmdserveropts *opts)
{ {
const char *hgcmd = gethgcmd(); const char *hgcmd = gethgcmd();
const char *baseargv[] = { const char *baseargv[] = {
hgcmd, hgcmd,
"serve", "serve",
"--no-profile",
"--cmdserver", "--cmdserver",
"chgunix", "chgunix",
"--address", "--address",
opts->initsockname, opts->initsockname,
"--daemon-postexec", "--daemon-postexec",
"chdir:/", "chdir:/",
}; };
size_t baseargvsize = sizeof(baseargv) / sizeof(baseargv[0]); size_t baseargvsize = sizeof(baseargv) / sizeof(baseargv[0]);

tests/test-chg.t

$ "$PYTHON" <<EOF $ "$PYTHON" <<EOF
> r1 = int(open("run_1", "r").read().split()[-1]) > r1 = int(open("run_1", "r").read().split()[-1])
> r4 = int(open("run_4", "r").read().split()[-1]) > r4 = int(open("run_4", "r").read().split()[-1])
> print("Run 1: %d samples\nRun 4: %d samples\nRun 4 > 3 * Run 1: %s" % > print("Run 1: %d samples\nRun 4: %d samples\nRun 4 > 3 * Run 1: %s" %
> (r1, r4, r4 > (r1 * 3))) > (r1, r4, r4 > (r1 * 3)))
> EOF > EOF
Run 1: * samples (glob) Run 1: * samples (glob)
Run 4: * samples (glob) Run 4: * samples (glob)
Run 4 > 3 * Run 1: True Run 4 > 3 * Run 1: False
(Disabling with --no-profile on the commandline still works, but isn't permanent) (Disabling with --no-profile on the commandline still works, but isn't permanent)
$ newchg log -r . --no-profile $ newchg log -r . --no-profile
$ filteredchg log -r . $ filteredchg log -r .
Sample count: * (glob) Sample count: * (glob)
$ filteredchg log -r . --no-profile $ filteredchg log -r . --no-profile
$ filteredchg log -r . $ filteredchg log -r .
Sample count: * (glob) Sample count: * (glob)