Page MenuHomePhabricator

tests: ensure `$PYTHON` is quoted for Windows
ClosedPublic

Authored by mharbison72 on May 3 2021, 2:21 PM.

Details

Summary

Global installs of python3 go into "Program Files", and tons of tests fail with
mysterious errors if this isn't quoted. Most of this is a followup to
0826d684a1b5, but a some of these were existing issues. Shebang lines are
ignored because quoting breaks direct execution- these will need to be launched
indirectly with the quoted $PYTHON command.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 3 2021, 2:21 PM
Alphare accepted this revision.May 6 2021, 12:26 PM
This revision is now accepted and ready to land.May 6 2021, 12:26 PM
baymax updated this revision to Diff 27672.May 6 2021, 1:16 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)
โš  This patch is intended for stable โš 

This revision was automatically updated to reflect the committed changes.