Page MenuHomePhabricator

tests: change the fixer commands to use the buffer attribute on stdio objects
ClosedPublic

Authored by mharbison72 on May 3 2021, 2:22 PM.

Details

Summary

Otherwise \r was getting injected into the fixed lines and throwing off the
commit hashes on Windows when the fixer is invoked with py3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 3 2021, 2:22 PM
Alphare accepted this revision.May 6 2021, 12:32 PM
This revision is now accepted and ready to land.May 6 2021, 12:32 PM
baymax updated this revision to Diff 27676.May 6 2021, 1:17 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠