This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10636

tests: stabilize test-persistent-nodemap.t on Windows
ClosedPublic

Authored by mharbison72 on May 3 2021, 2:22 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9e3979a25bfe: tests: stabilize test-persistent-nodemap.t on Windows
Summary

Several issues here:

  • Hooks can't invoke shell scripts on Windows, so use sh to launch
  • dd in MSYS only recognizes status=noxfer
  • The PATH updating triggered a massive slowdown, but is no longer needed

I have no idea why, but removing the PATH update substantially increased the
speed of the test. It was running finishing at ~4:30 with --debug and ~14:50
without it, but now completes in ~2:20 on my Windows laptop.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 3 2021, 2:22 PM
Alphare accepted this revision.May 6 2021, 12:29 PM
This revision is now accepted and ready to land.May 6 2021, 12:29 PM
baymax updated this revision to Diff 27675.May 6 2021, 1:17 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

mharbison72 added a commit: rHG9e3979a25bfe: tests: stabilize test-persistent-nodemap.t on Windows.May 6 2021, 1:20 PM
Closed by commit rHG9e3979a25bfe: tests: stabilize test-persistent-nodemap.t on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-persistent-nodemap.t (11 lines)

Diff 27680

tests/test-persistent-nodemap.t

data-unused: 192 (rust !) data-unused: 192 (rust !)
data-unused: 0 (no-pure no-rust !) data-unused: 0 (no-pure no-rust !)
data-unused: 0.158% (pure !) data-unused: 0.158% (pure !)
data-unused: 0.158% (rust !) data-unused: 0.158% (rust !)
data-unused: 0.000% (no-pure no-rust !) data-unused: 0.000% (no-pure no-rust !)
Another process does not see the pending nodemap content during run. Another process does not see the pending nodemap content during run.
$ PATH=$RUNTESTDIR/testlib/:$PATH
$ echo qpoasp > a $ echo qpoasp > a
$ hg ci -m a2 \ $ hg ci -m a2 \
> --config "hooks.pretxnclose=wait-on-file 20 sync-repo-read sync-txn-pending" \ > --config "hooks.pretxnclose=sh \"$RUNTESTDIR/testlib/wait-on-file\" 20 sync-repo-read sync-txn-pending" \
> --config "hooks.txnclose=touch sync-txn-close" > output.txt 2>&1 & > --config "hooks.txnclose=touch sync-txn-close" > output.txt 2>&1 &
(read the repository while the commit transaction is pending) (read the repository while the commit transaction is pending)
$ wait-on-file 20 sync-txn-pending && \ $ sh "$RUNTESTDIR/testlib/wait-on-file" 20 sync-txn-pending && \
> hg debugnodemap --metadata && \ > hg debugnodemap --metadata && \
> wait-on-file 20 sync-txn-close sync-repo-read > sh "$RUNTESTDIR/testlib/wait-on-file" 20 sync-txn-close sync-repo-read
uid: ???????????????? (glob) uid: ???????????????? (glob)
tip-rev: 5004 tip-rev: 5004
tip-node: 2f5fb1c06a16834c5679d672e90da7c5f3b1a984 tip-node: 2f5fb1c06a16834c5679d672e90da7c5f3b1a984
data-length: 121280 (pure !) data-length: 121280 (pure !)
data-length: 121280 (rust !) data-length: 121280 (rust !)
data-length: 121088 (no-pure no-rust !) data-length: 121088 (no-pure no-rust !)
data-unused: 192 (pure !) data-unused: 192 (pure !)
data-unused: 192 (rust !) data-unused: 192 (rust !)
corruption-test-repo/.hg/store/00changelog.i corruption-test-repo/.hg/store/00changelog.i
corruption-test-repo/.hg/store/00changelog.n corruption-test-repo/.hg/store/00changelog.n
truncate the file truncate the file
$ datafilepath=`ls corruption-test-repo/.hg/store/00changelog*.nd` $ datafilepath=`ls corruption-test-repo/.hg/store/00changelog*.nd`
$ f -s $datafilepath $ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=121088 (glob) corruption-test-repo/.hg/store/00changelog-*.nd: size=121088 (glob)
$ dd if=$datafilepath bs=1000 count=10 of=$datafilepath-tmp status=none $ dd if=$datafilepath bs=1000 count=10 of=$datafilepath-tmp status=noxfer
10+0 records in
10+0 records out
$ mv $datafilepath-tmp $datafilepath $ mv $datafilepath-tmp $datafilepath
$ f -s $datafilepath $ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=10000 (glob) corruption-test-repo/.hg/store/00changelog-*.nd: size=10000 (glob)
Check that Mercurial reaction to this event Check that Mercurial reaction to this event
$ hg -R corruption-test-repo log -r . --traceback $ hg -R corruption-test-repo log -r . --traceback
changeset: 5005:90d5d3ba2fc4 changeset: 5005:90d5d3ba2fc4