Page MenuHomePhabricator

tests: stabilize test-persistent-nodemap.t on Windows
ClosedPublic

Authored by mharbison72 on May 3 2021, 2:22 PM.

Details

Summary

Several issues here:

  • Hooks can't invoke shell scripts on Windows, so use sh to launch
  • dd in MSYS only recognizes status=noxfer
  • The PATH updating triggered a massive slowdown, but is no longer needed

I have no idea why, but removing the PATH update substantially increased the
speed of the test. It was running finishing at ~4:30 with --debug and ~14:50
without it, but now completes in ~2:20 on my Windows laptop.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 3 2021, 2:22 PM
Alphare accepted this revision.May 6 2021, 12:29 PM
This revision is now accepted and ready to land.May 6 2021, 12:29 PM
baymax updated this revision to Diff 27675.May 6 2021, 1:17 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)
โš  This patch is intended for stable โš 

This revision was automatically updated to reflect the committed changes.