This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-v2: Update the expected output of some tests for new requirement
ClosedPublic

Authored by SimonSapin on May 17 2021, 6:05 AM.

Details

Summary

Fix most test failures (except in test-narrow-debugrebuilddirstate.t and
test-upgrade-repo.t) caused by the new entry in config or in .hg/requires
when running run-tests.py --extra-config-opt format.exp-dirstate-v2=1

There is no CI so far for this configuration.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.May 17 2021, 6:05 AM
baymax updated this revision to Diff 27998.May 17 2021, 8:39 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added inline comments.
tests/hghave.py
1052

Should you be using stringutil.parsebool instead?

tests/test-config.t
162

That looks unrelated?

SimonSapin added inline comments.May 19 2021, 6:22 AM
tests/hghave.py
1052

Can we really import Mercurial modules from inside of hghave.py? That isn’t done so far

tests/test-config.t
162

Without this change, the hg config format command prints the whole format section of configuration including format.exp-dirstate-v2

Alphare accepted this revision.May 19 2021, 6:48 AM
Alphare added inline comments.
tests/hghave.py
1052

Right, probably not

This revision is now accepted and ready to land.May 19 2021, 6:48 AM
baymax updated this revision to Diff 28099.May 19 2021, 7:41 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)