( )⚙ D1079 hgweb: rewrite most obviously-native-strings to be native strings

This is an archive of the discontinued Mercurial Phabricator instance.

hgweb: rewrite most obviously-native-strings to be native strings
ClosedPublic

Authored by durin42 on Oct 14 2017, 4:16 PM.

Details

Summary

This clearly won't be everything, but it unblocks a fair amount of
stuff here.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 14 2017, 4:16 PM
indygreg accepted this revision.

There might be some subtle issues with encoding for e.g. form values (if we don't have a test for e.g. a Unicode value in a revset search, we should add one). But I'm sure @yuja will flag those if they exist. I'm happy to queue until then.

This revision is now accepted and ready to land.Oct 14 2017, 4:56 PM
This revision was automatically updated to reflect the committed changes.
yuja added a comment.Oct 14 2017, 11:16 PM

Please don't count on me that I can catch unicode issues around
Python URL/HTTP libraries. I hate Python 3 because of the unicode
mess, so I don't write it for any projects other than Mercurial.

Maybe we'll need a clear boundary between Mercurial and Python
types to determine which value should be bytes/unicode.