This is an archive of the discontinued Mercurial Phabricator instance.

Differential D890

urllibcompat: new library to help abstract out some python3 urllib2 stuff
ClosedPublic

Authored by durin42 on Oct 1 2017, 12:43 PM.

Details

Reviewers
yuja
pulkit
krbullock
Group Reviewers
hg-reviewers
Commits
rHG80d4681150b9: urllibcompat: new library to help abstract out some python3 urllib2 stuff
Summary

Doing a new file instead of pycompat because I'm starting to feel like
pycompat is getting a little enormous in terms of scope.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 1 2017, 12:43 PM
yuja requested changes to this revision.Oct 2 2017, 11:58 AM
yuja added a subscriber: yuja.

Please add GPL boilerplate.

FWIW, we might want to move some urllib-related hacks from pycompat.py.

This revision now requires changes to proceed.Oct 2 2017, 11:58 AM
durin42 added a comment.Oct 4 2017, 12:28 PM

boilerplate added

pulkit accepted this revision.Oct 4 2017, 2:13 PM
krbullock accepted this revision.Oct 4 2017, 3:48 PM
Closed by commit rHG80d4681150b9: urllibcompat: new library to help abstract out some python3 urllib2 stuff (authored by durin42). · Explain WhyOct 4 2017, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMmercurial/urllibcompat.py (42 lines)

Diff 2429

mercurial/urllibcompat.py

  • This file was added.
# urllibcompat.py - adapters to ease using urllib2 on Py2 and urllib on Py3
#
# Copyright 2017 Google, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from . import pycompat
if pycompat.ispy3:
def getfullurl(req):
return req.full_url
def gethost(req):
return req.host
def getselector(req):
return req.selector
def getdata(req):
return req.data
def hasdata(req):
return req.data is not None
else:
def gethost(req):
return req.get_host()
def getselector(req):
return req.get_selector()
def getfullurl(req):
return req.get_full_url()
def getdata(req):
return req.get_data()
def hasdata(req):
return req.has_data()