This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	2302		Oct 1 2017, 12:43 PM	★	★
Diff 2	2422		Oct 4 2017, 12:26 PM	★	★
Diff 3	2429	rHG80d4681150b93ced36592210f82bb9e210e4e060	Oct 1 2017, 10:45 AM	★	★

Status	Author	Revision
Closed	durin42	D1080 hgweb: fix logging to use native strings as appropriate
Closed	durin42	D1079 hgweb: rewrite most obviously-native-strings to be native strings
Closed	durin42	D1078 hgweb: use native strings consistently for querystring parsing
Closed	durin42	D1077 hgweb: rewrite two X or Y and Z ad-hoc ternaries with Y if X else Z
Closed	durin42	D1076 hgweb: more native string treatment in query string parsing
Closed	durin42	D1075 httppeer: pass url to urllib as native str, not bytes
Closed	durin42	D1067 python3: use our bytes-only version of cgi.escape everywhere
Closed	durin42	D1066 url: add cgi.escape equivalent for bytestrings
Closed	durin42	D1065 python3: move from using func_name to __name__
Closed	durin42	D891 cleanup: use urllibcompat for renamed methods on urllib request objects
Closed	durin42	D935 urllibcompat: move some adapters from pycompat to urllibcompat
Closed	durin42	D890 urllibcompat: new library to help abstract out some python3 urllib2 stuff
Closed	durin42	D889 url: use native strings for header values
Closed	durin42	D888 keepalive: python 3 portability tweaks
Closed	durin42	D887 httppeer: use native strings for headers
Closed	durin42	D886 ui: convert to/from Optional[bytes] to Optional[str] in password manager
Closed	durin42	D885 httppasswordmgrdbproxy: specify exact arguments

Diff 2422

				# urllibcompat.py - adapters to ease using urllib2 on Py2 and urllib on Py3
				#
				# Copyright 2017 Google, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.
				from __future__ import absolute_import

				from . import pycompat

				if pycompat.ispy3:

				def getfullurl(req):
				return req.full_url

				def gethost(req):
				return req.host

				def getselector(req):
				return req.selector

				def getdata(req):
				return req.data

				def hasdata(req):
				return req.data is not None
				else:

				def gethost(req):
				return req.get_host()

				def getselector(req):
				return req.get_selector()

				def getfullurl(req):
				return req.get_full_url()

				def getdata(req):
				return req.get_data()

				def hasdata(req):
				return req.has_data()