This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10831

index: use an explicit constant for INDEX_HEADER format and use it for docket
ClosedPublic

Authored by marmoute on Jun 2 2021, 4:14 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG298d4400ea68: index: use an explicit constant for INDEX_HEADER format and use it for docket
rHG165addb19772: index: use an explicit constant for INDEX_HEADER format and use it for docket
Summary

This avoid leaking python-3.6 compatibility details too much.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

Diff 28412

mercurial/revlogutils/constants.py

KIND_CHANGELOG, KIND_CHANGELOG,
KIND_MANIFESTLOG, KIND_MANIFESTLOG,
KIND_FILELOG, KIND_FILELOG,
KIND_OTHER, KIND_OTHER,
} }
### main revlog header ### main revlog header
INDEX_HEADER = struct.Struct(b">I") # We cannot rely on Struct.format is inconsistent for python <=3.6 versus above
INDEX_HEADER_FMT = b">I"
INDEX_HEADER = struct.Struct(INDEX_HEADER_FMT)
## revlog version ## revlog version
REVLOGV0 = 0 REVLOGV0 = 0
REVLOGV1 = 1 REVLOGV1 = 1
# Dummy value until file format is finalized. # Dummy value until file format is finalized.
REVLOGV2 = 0xDEAD REVLOGV2 = 0xDEAD
# Dummy value until file format is finalized. # Dummy value until file format is finalized.
CHANGELOGV2 = 0xD34D CHANGELOGV2 = 0xD34D

mercurial/revlogutils/docket.py

# | revlog index header. # | revlog index header.
# * 1 bytes: size of index uuid # * 1 bytes: size of index uuid
# * 1 bytes: size of data uuid # * 1 bytes: size of data uuid
# * 8 bytes: size of index-data # * 8 bytes: size of index-data
# * 8 bytes: pending size of index-data # * 8 bytes: pending size of index-data
# * 8 bytes: size of data # * 8 bytes: size of data
# * 8 bytes: pending size of data # * 8 bytes: pending size of data
# * 1 bytes: default compression header # * 1 bytes: default compression header
S_HEADER = struct.Struct( S_HEADER = struct.Struct(constants.INDEX_HEADER_FMT + b'BBLLLLc')
pycompat.sysstr(constants.INDEX_HEADER.format) + 'BBLLLLc'
)
class RevlogDocket(object): class RevlogDocket(object):
"""metadata associated with revlog""" """metadata associated with revlog"""
def __init__( def __init__(
self, self,
revlog, revlog,