This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10780

revlog: implement sidedata without using _revisiondata
ClosedPublic

Authored by marmoute on May 28 2021, 6:56 PM.

Details

Reviewers
indygreg
Alphare
Group Reviewers
hg-reviewers
Commits
rHGd6a52783d2ba: revlog: implement sidedata without using _revisiondata
Summary

When they was introduced sidedata where grouped with the actual revision data
and unpacking one came with the other. Sidedata moved be stored "independently"
and it no longer make sense to retrieve both at the same time unconditionnaly.
We start with changeset the implementation of the revlog.sidedata command to
no longer use self._revisiondata. More users need to be migrated to direct
usage of this revlog.sidedata method. This will be done in the coming
changesets.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 28 2021, 6:56 PM
Alphare accepted this revision as: Alphare.May 31 2021, 6:12 AM
baymax updated this revision to Diff 28293.May 31 2021, 6:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28390.Jun 1 2021, 11:10 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28439.Jun 4 2021, 9:54 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHGd6a52783d2ba: revlog: implement sidedata without using _revisiondata.Jun 7 2021, 5:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd6a52783d2ba: revlog: implement sidedata without using _revisiondata (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (7 lines)

Diff 28484

mercurial/revlog.py

def sidedata(self, nodeorrev, _df=None): def sidedata(self, nodeorrev, _df=None):
"""a map of extra data related to the changeset but not part of the hash """a map of extra data related to the changeset but not part of the hash
This function currently return a dictionary. However, more advanced This function currently return a dictionary. However, more advanced
mapping object will likely be used in the future for a more mapping object will likely be used in the future for a more
efficient/lazy code. efficient/lazy code.
""" """
return self._revisiondata(nodeorrev, _df)[1] # deal with <nodeorrev> argument type
if isinstance(nodeorrev, int):
rev = nodeorrev
else:
rev = self.rev(nodeorrev)
return self._sidedata(rev)
def _revisiondata(self, nodeorrev, _df=None, raw=False): def _revisiondata(self, nodeorrev, _df=None, raw=False):
# deal with <nodeorrev> argument type # deal with <nodeorrev> argument type
if isinstance(nodeorrev, int): if isinstance(nodeorrev, int):
rev = nodeorrev rev = nodeorrev
node = self.node(rev) node = self.node(rev)
else: else:
node = nodeorrev node = nodeorrev