This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10779

revlogv2: drop "sidedatacompression" from the list of todos
ClosedPublic

Authored by marmoute on May 28 2021, 6:56 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG8aa3968c6d44: revlogv2: drop "sidedatacompression" from the list of todos
Summary

This was implemented in c4dbb7636a12 and 07641bafa646, but I forgot to drop it
from the todo-list.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 28 2021, 6:56 PM
Alphare accepted this revision as: Alphare.May 31 2021, 6:11 AM
baymax updated this revision to Diff 28292.May 31 2021, 6:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28389.Jun 1 2021, 11:10 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28438.Jun 4 2021, 9:54 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG8aa3968c6d44: revlogv2: drop "sidedatacompression" from the list of todos.Jun 7 2021, 5:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8aa3968c6d44: revlogv2: drop "sidedatacompression" from the list of todos (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (1 line)

Diff 28482

mercurial/configitems.py

# - for censoring operation # - for censoring operation
# - for stripping operation # - for stripping operation
# - for rollback operation # - for rollback operation
# * proper streaming (race free) of the docket file # * proper streaming (race free) of the docket file
# * track garbage data to evemtually allow rewriting -existing- sidedata. # * track garbage data to evemtually allow rewriting -existing- sidedata.
# * Exchange-wise, we will also need to do something more efficient than # * Exchange-wise, we will also need to do something more efficient than
# keeping references to the affected revlogs, especially memory-wise when # keeping references to the affected revlogs, especially memory-wise when
# rewriting sidedata. # rewriting sidedata.
# * sidedata compression
# * introduce a proper solution to reduce the number of filelog related files. # * introduce a proper solution to reduce the number of filelog related files.
# * Improvement to consider # * Improvement to consider
# - avoid compression header in chunk using the default compression? # - avoid compression header in chunk using the default compression?
# - forbid "inline" compression mode entirely? # - forbid "inline" compression mode entirely?
# - split the data offset and flag field (the 2 bytes save are mostly trouble) # - split the data offset and flag field (the 2 bytes save are mostly trouble)
# - keep track of uncompressed -chunk- size (to preallocate memory better) # - keep track of uncompressed -chunk- size (to preallocate memory better)
# - keep track of chain base or size (probably not that useful anymore) # - keep track of chain base or size (probably not that useful anymore)
# - store data and sidedata in different files # - store data and sidedata in different files