This is an archive of the discontinued Mercurial Phabricator instance.

copyfiles: deal with existing file when hardlinking

Authored by marmoute on Jun 9 2021, 10:37 AM.



If the hardlinking fails, we fallback to shutil.copy, but do not consider
future hardlinking doomed.

This is a slight improvement from the current situation, we still avoid
hardliking in a case we might be able to do it. However this does not have an
impact of the rest of the operation.

(This is an opportunity improvement while looking at something next to that.)

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 9 2021, 10:37 AM
pulkit accepted this revision.Jun 14 2021, 4:37 PM
This revision is now accepted and ready to land.Jun 14 2021, 4:37 PM
This revision was automatically updated to reflect the committed changes.