This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10851

vfs: add a `register_file` method on the vfs class
ClosedPublic

Authored by marmoute on Jun 9 2021, 10:37 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9ab54aa56982: vfs: add a `register_file` method on the vfs class
Summary

This is used by the fncache vfs to register new file. Until now, fncache have
been doing this "automatically" by monitoring write pattern. However this is
fragile and when we copy files in place by other means, we need something more
robuts. So we add an explicit method to do so.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 9 2021, 10:37 AM
pulkit accepted this revision.Jun 14 2021, 4:43 PM
This revision is now accepted and ready to land.Jun 14 2021, 4:43 PM
baymax updated this revision to Diff 28573.Jun 15 2021, 10:23 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jun 16 2021, 4:02 AM
baymax updated this revision to Diff 28621.Jun 21 2021, 1:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG9ab54aa56982: vfs: add a `register_file` method on the vfs class.Jun 21 2021, 11:13 AM
Closed by commit rHG9ab54aa56982: vfs: add a `register_file` method on the vfs class (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/store.py (5 lines)
Mmercurial/vfs.py (3 lines)

Diff 28651

mercurial/store.py

return self.vfs(encoded, mode, *args, **kw) return self.vfs(encoded, mode, *args, **kw)
def join(self, path): def join(self, path):
if path: if path:
return self.vfs.join(self.encode(path)) return self.vfs.join(self.encode(path))
else: else:
return self.vfs.join(path) return self.vfs.join(path)
def register_file(self, path):
"""generic hook point to lets fncache steer its stew"""
if path.startswith(b'data/') or path.startswith(b'meta/'):
self.fncache.add(path)
class fncachestore(basicstore): class fncachestore(basicstore):
def __init__(self, path, vfstype, dotencode): def __init__(self, path, vfstype, dotencode):
if dotencode: if dotencode:
encode = _pathencode encode = _pathencode
else: else:
encode = _plainhybridencode encode = _plainhybridencode
self.encode = encode self.encode = encode

mercurial/vfs.py

bfc # pytype: disable=attribute-error bfc # pytype: disable=attribute-error
) )
yield bfc yield bfc
finally: finally:
vfs._backgroundfilecloser = ( vfs._backgroundfilecloser = (
None # pytype: disable=attribute-error None # pytype: disable=attribute-error
) )
def register_file(self, path):
"""generic hook point to lets fncache steer its stew"""
class vfs(abstractvfs): class vfs(abstractvfs):
"""Operate files relative to a base directory """Operate files relative to a base directory
This class is used to hide the details of COW semantics and This class is used to hide the details of COW semantics and
remote file access from higher level code. remote file access from higher level code.
'cacheaudited' should be enabled only if (a) vfs object is short-lived, or 'cacheaudited' should be enabled only if (a) vfs object is short-lived, or