| indygreg | |
| Alphare |
| hg-reviewers |
It is a bit verbose and rough, but it works. Most of that logic can be common
for stripping, so we can expect more refactoring of that code to accommodate
both needs. However I wanted to keep this changesets "simple enough" and before
moving forward.
We also need to properly delete the older index/data/sidedata file, but this has
implication for streaming clone and transaction, so this will come later.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| mercurial/revlogutils/censor.py | ||
|---|---|---|
| 153 | We should replace cut_off to cutoff in all of those signatures, since it's the noun and not the verb, to avoid confusion | |
| 224 | Should be all_files | |
| 301 | data_delta_base, start, end, rewritten_entries[rev] should be data_delta_base, start, end = rewritten_entries[rev]. This makes me think that the censor tests do not look at the case where a revs have a censored node as delta base, which wouldn't be surprising since the last version didn't handle this. But we should add a test case for this. | |
| mercurial/revlogutils/censor.py | ||
|---|---|---|
| 189 | I'm not really sure I understand what we're doing here with the compression settings. (also, the comment about tell() is not at the right place anymore) | |