Page MenuHomePhabricator

templater: explode if we try to emit a str
ClosedPublic

Authored by durin42 on Oct 15 2017, 12:57 AM.

Details

Summary

Without this if branch, we infinitely recurse in _flatten, which is
very confusing. Something in an hgweb template is trying to write out
a string instead of a bytes on Python 3, and this at least makes it
crash politely.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 15 2017, 12:57 AM
yuja accepted this revision.Oct 15 2017, 9:20 AM
This revision is now accepted and ready to land.Oct 15 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.