Page MenuHomePhabricator

peer: when collecting method names for batch calls, bytes-ify __name__
ClosedPublic

Authored by durin42 on Oct 15 2017, 12:58 AM.

Details

Summary

This will explode violently if we have a non-ascii command name. That
shouldn't ever happen in core, and seems unlikely even in third-party
code. Regardless, it'll explode violently, so we can revisit things in
the future if we need to change the encoding here.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 15 2017, 12:58 AM
yuja accepted this revision.Oct 15 2017, 9:20 AM
This revision is now accepted and ready to land.Oct 15 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.