Page MenuHomePhabricator

wireproto: use listcomp instead of map()
ClosedPublic

Authored by durin42 on Oct 15 2017, 9:30 PM.

Details

Summary

The latter returns a generator object on Python 3, which breaks
various parts of hg that expected a list.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 15 2017, 9:30 PM
ryanmce accepted this revision.Oct 16 2017, 5:15 AM
ryanmce added a subscriber: ryanmce.

queued

This revision is now accepted and ready to land.Oct 16 2017, 5:15 AM
This revision was automatically updated to reflect the committed changes.