This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10885

debugbackupbundle: use new context manager for silencing the ui
ClosedPublic

Authored by martinvonz on Jun 18 2021, 7:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1be9bf3669cb: debugbackupbundle: use new context manager for silencing the ui
Summary

A difference between setting ui.quiet and using ui.silent() is
that the latter also silences ui.write() calls. That's practically
always what one wants, including here, I think.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (17 lines)

Diff 28642

mercurial/debugcommands.py

continue continue
revs, checkout = hg.addbranchrevs( revs, checkout = hg.addbranchrevs(
repo, other, branches, opts.get(b"rev") repo, other, branches, opts.get(b"rev")
) )
if revs: if revs:
revs = [other.lookup(rev) for rev in revs] revs = [other.lookup(rev) for rev in revs]
quiet = ui.quiet with ui.silent():
try: try:
ui.quiet = True
other, chlist, cleanupfn = bundlerepo.getremotechanges( other, chlist, cleanupfn = bundlerepo.getremotechanges(
ui, repo, other, revs, opts[b"bundle"], opts[b"force"] ui, repo, other, revs, opts[b"bundle"], opts[b"force"]
) )
except error.LookupError: except error.LookupError:
continue continue
finally:
ui.quiet = quiet
try: try:
if not chlist: if not chlist:
continue continue
if recovernode: if recovernode:
with repo.lock(), repo.transaction(b"unbundle") as tr: with repo.lock(), repo.transaction(b"unbundle") as tr:
if scmutil.isrevsymbol(other, recovernode): if scmutil.isrevsymbol(other, recovernode):
ui.status(_(b"Unbundling %s\n") % (recovernode)) ui.status(_(b"Unbundling %s\n") % (recovernode))