( )⚙ D10906 rhg: fallback if tweakdefaults or statuscopies is enabled with status

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10906

rhg: fallback if tweakdefaults or statuscopies is enabled with status
ClosedPublic

Authored by pulkit on Jun 24 2021, 2:04 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG64b8676f11bb: rhg: fallback if tweakdefaults or statuscopies is enabled with status
Summary

rhg status is experimental right now and does not support all functionalities.
While the long term target is to implement them, for now we add a fallback to
have all tests pass with rhg status enabled.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jun 24 2021, 2:04 PM
SimonSapin added a subscriber: SimonSapin.Jun 24 2021, 2:27 PM

Nit: These match + if pairs can be folded into a single if invocation.config.get_bool(b"ui", b"tweakdefaults") == Some(true) each.

Other than this, looks good.

pulkit updated this revision to Diff 28694.Jun 24 2021, 5:20 PM
Alphare accepted this revision.Jul 2 2021, 12:38 PM
This revision is now accepted and ready to land.Jul 2 2021, 12:38 PM
pulkit updated this revision to Diff 30673.Oct 5 2021, 7:49 AM

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/commands/status.rs (12 lines)

Diff 30673

rust/rhg/src/commands/status.rs

let status_enabled = invocation.config.get_option(b"rhg", b"status")?; let status_enabled = invocation.config.get_option(b"rhg", b"status")?;
if !status_enabled.unwrap_or(status_enabled_default) { if !status_enabled.unwrap_or(status_enabled_default) {
return Err(CommandError::unsupported( return Err(CommandError::unsupported(
"status is experimental in rhg (enable it with 'rhg.status = true' \ "status is experimental in rhg (enable it with 'rhg.status = true' \
or enable fallback with 'rhg.on-unsupported = fallback')" or enable fallback with 'rhg.on-unsupported = fallback')"
)); ));
} }
// TODO: lift these limitations
if invocation.config.get_bool(b"ui", b"tweakdefaults").ok() == Some(true) {
return Err(CommandError::unsupported(
"ui.tweakdefaults is not yet supported with rhg status",
));
}
if invocation.config.get_bool(b"ui", b"statuscopies").ok() == Some(true) {
return Err(CommandError::unsupported(
"ui.statuscopies is not yet supported with rhg status",
));
}
let ui = invocation.ui; let ui = invocation.ui;
let args = invocation.subcommand_args; let args = invocation.subcommand_args;
let display_states = if args.is_present("all") { let display_states = if args.is_present("all") {
// TODO when implementing `--quiet`: it excludes clean files // TODO when implementing `--quiet`: it excludes clean files
// from `--all` // from `--all`
ALL_DISPLAY_STATES ALL_DISPLAY_STATES
} else { } else {
let requested = DisplayStates { let requested = DisplayStates {