( )⚙ D10945 test: clarify some output in `test-transaction-rollback-on-sigpipe`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10945

test: clarify some output in `test-transaction-rollback-on-sigpipe`
ClosedPublic

Authored by marmoute on Jul 2 2021, 9:41 PM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG452795b0b69a: test: clarify some output in `test-transaction-rollback-on-sigpipe`
Summary

We don't want a dirty transaction to remain, but need to check the transaction
was aborted. Otherwise it is easy to have no abandoned transaction if the
transaction succeed.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 2 2021, 9:41 PM
Alphare accepted this revision.Jul 5 2021, 5:33 AM
This revision is now accepted and ready to land.Jul 5 2021, 5:33 AM
baymax updated this revision to Diff 28815.Jul 5 2021, 5:04 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 8 2021, 4:04 AM
baymax updated this revision to Diff 29000.Jul 8 2021, 10:22 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

Diff 29000

tests/test-transaction-rollback-on-sigpipe.t

> exit 1 > exit 1
> EOF > EOF
$ cat >remote/.hg/hgrc <<EOF $ cat >remote/.hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxnchangegroup.break-things=$hook_script > pretxnchangegroup.break-things=$hook_script
> EOF > EOF
$ hg --cwd ./remote tip -T '{node|short}\n'
000000000000
$ cd local $ cd local
$ echo foo > foo ; hg commit -qAm "commit" $ echo foo > foo ; hg commit -qAm "commit"
$ hg push -q -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 | grep -v $killable_pipe $ hg push -q -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 | grep -v $killable_pipe
abort: stream ended unexpectedly (got 0 bytes, expected 4) abort: stream ended unexpectedly (got 0 bytes, expected 4)
The remote should be left in a good state The remote should be left in a good state
$ hg --cwd ../remote tip -T '{node|short}\n'
000000000000
$ hg --cwd ../remote recover $ hg --cwd ../remote recover
no interrupted transaction available no interrupted transaction available
[1] [1]