This is an archive of the discontinued Mercurial Phabricator instance.

test: clarify some output in `test-transaction-rollback-on-sigpipe`
ClosedPublic

Authored by marmoute on Jul 2 2021, 9:41 PM.

Download Raw Diff

Details

Reviewers

Alphare
pulkit

Group Reviewers

hg-reviewers

Commits

rHG452795b0b69a: test: clarify some output in `test-transaction-rollback-on-sigpipe`

Summary

We don't want a dirty transaction to remain, but need to check the transaction
was aborted. Otherwise it is easy to have no abandoned transaction if the
transaction succeed.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 2 2021, 9:41 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJul 2 2021, 9:41 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D10946: test: make sure we hit the SIGPIPE in test-transaction-rollback-on-sigpipe.Jul 2 2021, 9:41 PM

Alphare accepted this revision.Jul 5 2021, 5:33 AM

This revision is now accepted and ready to land.Jul 5 2021, 5:33 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 8 2021, 4:04 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG452795b0b69a: test: clarify some output in `test-transaction-rollback-on-sigpipe`.Jul 8 2021, 10:36 AM

Closed by commit rHG452795b0b69a: test: clarify some output in `test-transaction-rollback-on-sigpipe` (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-transaction-rollback-on-sigpipe.t (4 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	28751		Jul 2 2021, 9:41 PM	★	★
Diff 2	28815		Jul 5 2021, 5:04 PM	★	★
Diff 3	29000		Jul 8 2021, 10:22 AM	★	★
Diff 4	29003	rHG452795b0b69ad533186cc5eea2a948146a624aa6	Jul 2 2021, 2:22 PM	★	★

Status	Author	Revision
Closed	marmoute	D10947 test: use a python script in `test-transaction-rollback-on-sigpipe.t`
Closed	marmoute	D10946 test: make sure we hit the SIGPIPE in test-transaction-rollback-on-sigpipe
Closed	marmoute	D10945 test: clarify some output in `test-transaction-rollback-on-sigpipe`
Abandoned	marmoute	D10944 check-shbang: accept -S with env
Closed	marmoute	D10943 run-tests: stop writing a `python3` symlink pointing to python2
Closed	marmoute	D10994 check-code: stop forbidding return code result
Closed	marmoute	D10942 run-tests: avoid an early return
Closed	marmoute	D10941 run-tests: clarify pyexename assignement
Closed	marmoute	D10940 run-tests: factor appdata out
Closed	marmoute	D10939 run-tests: unroll a non-so-one-liner
Closed	marmoute	D10938 run-tests: unroll a non-so-one-liner
Closed	marmoute	D10937 testing: fix _timeout_factor

Diff 29003

tests/test-transaction-rollback-on-sigpipe.t

	> exit 1			> exit 1
	> EOF			> EOF

	$ cat >remote/.hg/hgrc <<EOF			$ cat >remote/.hg/hgrc <<EOF
	> [hooks]			> [hooks]
	> pretxnchangegroup.break-things=$hook_script			> pretxnchangegroup.break-things=$hook_script
	> EOF			> EOF

				$ hg --cwd ./remote tip -T '{node\|short}\n'
				000000000000
	$ cd local			$ cd local
	$ echo foo > foo ; hg commit -qAm "commit"			$ echo foo > foo ; hg commit -qAm "commit"
	$ hg push -q -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 \| grep -v $killable_pipe			$ hg push -q -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 \| grep -v $killable_pipe
	abort: stream ended unexpectedly (got 0 bytes, expected 4)			abort: stream ended unexpectedly (got 0 bytes, expected 4)

	The remote should be left in a good state			The remote should be left in a good state
				$ hg --cwd ../remote tip -T '{node\|short}\n'
				000000000000
	$ hg --cwd ../remote recover			$ hg --cwd ../remote recover
	no interrupted transaction available			no interrupted transaction available
	[1]			[1]