Details
- Reviewers
Alphare marmoute - Group Reviewers
hg-reviewers
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Can we test that further descendants (potentially not linear) are not rebased automatically? This can be done in a separate, simpler test case as an additional changeset.
I think that's now done. I also added tests for amending into non-ancestors (in the first patch in this series).
| hgext/amend.py | ||
|---|---|---|
| 182–185 | It would be nice to have some documentation about what each of these value mean, there start to be many of them and I am not sure what each of them is about. | |
| 303 | What happens (and what's is the intend) if any of the nodes here are obsolete ? | |
| 312 | Using tip here seem a bit fragile. The only(tip, <amended>) range seems strange since this will include changeset that are not descendant of <target>, so over reporting. (we need a test for that). In addition if some node got skipped or "disappeared for being empty post rebase". It feel like we have a good odd of bad/confusing report. | |