( )⚙ D11206 typing: convert an annotation to an assertion in commands.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11206

typing: convert an annotation to an assertion in commands.py
ClosedPublic

Authored by mharbison72 on Jul 21 2021, 4:07 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG76dccbbe73fd: typing: convert an annotation to an assertion in commands.py
Summary

Pytype was happy with the annotation at one point, but 2021.04.15 now complains.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Jul 21 2021, 4:07 PM
Alphare accepted this revision.Jul 22 2021, 12:01 PM
This revision is now accepted and ready to land.Jul 22 2021, 12:01 PM
Alphare added a comment.Jul 22 2021, 12:08 PM

I'm assuming both patches were intended for stable?

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (3 lines)

Diff 29704

mercurial/commands.py

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
) )
if node is None: if node is None:
ui.warn( ui.warn(
_(b'note: graft of %d:%s created no changes to commit\n') _(b'note: graft of %d:%s created no changes to commit\n')
% (ctx.rev(), ctx) % (ctx.rev(), ctx)
) )
# checking that newnodes exist because old state files won't have it # checking that newnodes exist because old state files won't have it
elif statedata.get(b'newnodes') is not None: elif statedata.get(b'newnodes') is not None:
nn = statedata[b'newnodes'] # type: List[bytes] nn = statedata[b'newnodes']
assert isinstance(nn, list) # list of bytes
nn.append(node) nn.append(node)
# remove state when we complete successfully # remove state when we complete successfully
if not opts.get('dry_run'): if not opts.get('dry_run'):
graftstate.delete() graftstate.delete()
return 0 return 0