Page MenuHomePhabricator

issue6528: add a config option to control the fixing on the fly
ClosedPublic

Authored by marmoute on Aug 7 2021, 12:58 PM.

Details

Summary

This will allow people who know to be safe to avoid any performance overhead
(and other potential issue).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 7 2021, 12:58 PM
baymax updated this revision to Diff 29862.Aug 8 2021, 5:22 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)
โš  This patch is intended for stable โš 

Note to other reviewers: I'm on vacation so I probably won't be queuing patches too much, I wanted to check up on the rest of my series.

tests/test-issue6528.t
595

Those comments say the opposite of what they're trying to

marmoute planned changes to this revision.Aug 8 2021, 4:08 PM
marmoute added inline comments.
tests/test-issue6528.t
595

The copy-paste devil strike again. Thanks for spotting this, update on the way.

baymax updated this revision to Diff 29864.Aug 8 2021, 6:59 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)
โš  This patch is intended for stable โš 

pulkit accepted this revision.Aug 10 2021, 8:19 AM
This revision is now accepted and ready to land.Aug 10 2021, 8:19 AM

Can we add details to releasenotes about debugcommand and config option introduced for the bug fix?