( )⚙ D11286 pyoxidized: add a dedicated target in the tests

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11286

pyoxidized: add a dedicated target in the tests
ClosedPublic

Authored by marmoute on Aug 17 2021, 9:00 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd3f890e04525: pyoxidized: add a dedicated target in the tests
Summary

We will need to setup more items to make the "quick" version work on stable,
having a dedicated operation will allow to contains change to that operation.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Aug 17 2021, 9:00 PM
mharbison72 added a subscriber: mharbison72.Aug 18 2021, 12:07 AM
mharbison72 added inline comments.
Makefile
275

Needs .PHONY?

baymax updated this revision to Diff 29910.Aug 18 2021, 6:46 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

marmoute added a commit: rHGd3f890e04525: pyoxidized: add a dedicated target in the tests.Aug 18 2021, 9:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd3f890e04525: pyoxidized: add a dedicated target in the tests (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MMakefile (6 lines)
Mtests/run-tests.py (2 lines)

Diff 29910

Makefile

--package-path build/ \ --package-path build/ \
--version "$${HGVER}" \ --version "$${HGVER}" \
--resources contrib/packaging/macosx/ \ --resources contrib/packaging/macosx/ \
"$${OUTPUTDIR:-dist/}"/Mercurial-"$${HGVER}"-macosx"$${OSXVER}".pkg "$${OUTPUTDIR:-dist/}"/Mercurial-"$${HGVER}"-macosx"$${OSXVER}".pkg
pyoxidizer: pyoxidizer:
$(PYOXIDIZER) build --path ./rust/hgcli --release $(PYOXIDIZER) build --path ./rust/hgcli --release
# a temporary target to setup all we need for run-tests.py --pyoxidizer
# (should go away as the run-tests implementation improves
pyoxidizer-windows-tests: pyoxidizer
mharbison72Unsubmitted
Not Done

Needs .PHONY?

mharbison72: Needs `.PHONY`?
.PHONY: help all local build doc cleanbutpackages clean install install-bin \ .PHONY: help all local build doc cleanbutpackages clean install install-bin \
install-doc install-home install-home-bin install-home-doc \ install-doc install-home install-home-bin install-home-doc \
dist dist-notests check tests rust-tests check-code format-c \ dist dist-notests check tests rust-tests check-code format-c \
update-pot pyoxidizer \ update-pot pyoxidizer pyoxidizer-windows-tests \
$(packaging_targets) \ $(packaging_targets) \
osx osx

tests/run-tests.py

Ideally this function would be `install_pyoxidier` and would both build Ideally this function would be `install_pyoxidier` and would both build
and install pyoxidier. However we are starting small to get pyoxidizer and install pyoxidier. However we are starting small to get pyoxidizer
build binary to testing quickly. build binary to testing quickly.
""" """
vlog('# build a pyoxidized version of Mercurial') vlog('# build a pyoxidized version of Mercurial')
assert os.path.dirname(self._bindir) == self._installdir assert os.path.dirname(self._bindir) == self._installdir
assert self._hgroot, 'must be called after _installhg()' assert self._hgroot, 'must be called after _installhg()'
cmd = b'"%(make)s" pyoxidizer' % { cmd = b'"%(make)s" pyoxidizer-windows-tests' % {
b'make': b'make', b'make': b'make',
} }
cwd = self._hgroot cwd = self._hgroot
vlog("# Running", cmd) vlog("# Running", cmd)
proc = subprocess.Popen( proc = subprocess.Popen(
_bytes2sys(cmd), _bytes2sys(cmd),
shell=True, shell=True,
cwd=_bytes2sys(cwd), cwd=_bytes2sys(cwd),