This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1130

contrib: remove check-code rule about indentation
ClosedPublic

Authored by durin42 on Oct 16 2017, 9:53 PM.

Details

Reviewers
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG0b46352384a0: contrib: remove check-code rule about indentation
Summary

We're moving towards a clang-format world, and clang-format is able to
wrap argument lists with spaces reliably, while still enforcing tabs
globally. Let's let clang-format do its job, and not do as much
C-style enforcement with regular expressions.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 9:53 PM
ryanmce accepted this revision.Oct 17 2017, 7:44 AM
This revision is now accepted and ready to land.Oct 17 2017, 7:44 AM
Closed by commit rHG0b46352384a0: contrib: remove check-code rule about indentation (authored by durin42). · Explain WhyOct 17 2017, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 2896

contrib/check-code.py

('.. note::[ \n][^\n]', 'add two newlines after note::') ('.. note::[ \n][^\n]', 'add two newlines after note::')
], ],
[] []
] ]
cpats = [ cpats = [
[ [
(r'//', "don't use //-style comments"), (r'//', "don't use //-style comments"),
(r'^ ', "don't use spaces to indent"),
(r'\S\t', "don't use tabs except for indent"), (r'\S\t', "don't use tabs except for indent"),
(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
(r'.{81}', "line too long"), (r'.{81}', "line too long"),
(r'(while|if|do|for)\(', "use space after while/if/do/for"), (r'(while|if|do|for)\(', "use space after while/if/do/for"),
(r'return\(', "return is not a function"), (r'return\(', "return is not a function"),
(r' ;', "no space before ;"), (r' ;', "no space before ;"),
(r'[^;] \)', "no space before )"), (r'[^;] \)', "no space before )"),
(r'[)][{]', "space between ) and {"), (r'[)][{]', "space between ) and {"),