This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1133

test-clang-format: new test to verify that files stay clang-formatted
ClosedPublic

Authored by durin42 on Oct 16 2017, 9:53 PM.

Details

Reviewers
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG2e8477059d4f: test-clang-format: new test to verify that files stay clang-formatted
Summary

For now all .c and .h files are blacklisted. As they become
clang-formatted, we'll remove them from the blacklist,and then this
test will produce output if there are diffs.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 9:53 PM
ryanmce requested changes to this revision.Oct 17 2017, 7:36 AM
ryanmce added a subscriber: ryanmce.
ryanmce added inline comments.
tests/test-check-clang-format.t
2

This test fails for me with errors about lz4revlog.

It feels like what we need here is a change similar to 6c113a7dec52, where we use the system hg to examine the local repository. Please reuse the syshg function here.

This revision now requires changes to proceed.Oct 17 2017, 7:36 AM
durin42 updated this revision to Diff 2916.Oct 17 2017, 10:21 AM
durin42 added inline comments.Oct 17 2017, 10:21 AM
tests/test-check-clang-format.t
2

Derp, this is done.

ryanmce added a comment.Oct 17 2017, 5:18 PM

I get skipped: unknown feature: clang-format when running test-check-clang-format.t now. What am I doing wrong?

quark added a subscriber: quark.EditedOct 17 2017, 5:27 PM
In D1133#19539, @ryanmce wrote:

I get skipped: unknown feature: clang-format when running test-check-clang-format.t now. What am I doing wrong?

Are you using run-tests.py from this repo and running it in the tests/ directory from this repo?

(and this repo has 15b561fffde5)

ryanmce accepted this revision.Oct 17 2017, 5:31 PM

Yeah, I was running the wrong run-tests.py. Thanks for the help @durin42.

queued

This revision is now accepted and ready to land.Oct 17 2017, 5:31 PM
Closed by commit rHG2e8477059d4f: test-clang-format: new test to verify that files stay clang-formatted (authored by durin42). · Explain WhyOct 17 2017, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2948

contrib/clang-format-blacklist

  • This file was added.
# Files that just need to be migrated to the formatter.
# Do not add new files here!
contrib/chg/chg.c
contrib/chg/hgclient.c
contrib/chg/hgclient.h
contrib/chg/procutil.c
contrib/chg/procutil.h
contrib/chg/util.c
contrib/chg/util.h
contrib/hgsh/hgsh.c
mercurial/cext/base85.c
mercurial/cext/bdiff.c
mercurial/cext/charencode.c
mercurial/cext/charencode.h
mercurial/cext/diffhelpers.c
mercurial/cext/dirs.c
mercurial/cext/manifest.c
mercurial/cext/mpatch.c
mercurial/cext/osutil.c
mercurial/cext/parsers.c
mercurial/cext/pathencode.c
mercurial/cext/revlog.c
# Vendored code that we should never format:
contrib/python-zstandard/c-ext/bufferutil.c
contrib/python-zstandard/c-ext/compressiondict.c
contrib/python-zstandard/c-ext/compressionparams.c
contrib/python-zstandard/c-ext/compressionwriter.c
contrib/python-zstandard/c-ext/compressobj.c
contrib/python-zstandard/c-ext/compressor.c
contrib/python-zstandard/c-ext/compressoriterator.c
contrib/python-zstandard/c-ext/constants.c
contrib/python-zstandard/c-ext/decompressionwriter.c
contrib/python-zstandard/c-ext/decompressobj.c
contrib/python-zstandard/c-ext/decompressor.c
contrib/python-zstandard/c-ext/decompressoriterator.c
contrib/python-zstandard/c-ext/frameparams.c
contrib/python-zstandard/c-ext/python-zstandard.h
contrib/python-zstandard/zstd.c
contrib/python-zstandard/zstd/common/bitstream.h
contrib/python-zstandard/zstd/common/entropy_common.c
contrib/python-zstandard/zstd/common/error_private.c
contrib/python-zstandard/zstd/common/error_private.h
contrib/python-zstandard/zstd/common/fse.h
contrib/python-zstandard/zstd/common/fse_decompress.c
contrib/python-zstandard/zstd/common/huf.h
contrib/python-zstandard/zstd/common/mem.h
contrib/python-zstandard/zstd/common/pool.c
contrib/python-zstandard/zstd/common/pool.h
contrib/python-zstandard/zstd/common/threading.c
contrib/python-zstandard/zstd/common/threading.h
contrib/python-zstandard/zstd/common/xxhash.c
contrib/python-zstandard/zstd/common/xxhash.h
contrib/python-zstandard/zstd/common/zstd_common.c
contrib/python-zstandard/zstd/common/zstd_errors.h
contrib/python-zstandard/zstd/common/zstd_internal.h
contrib/python-zstandard/zstd/compress/fse_compress.c
contrib/python-zstandard/zstd/compress/huf_compress.c
contrib/python-zstandard/zstd/compress/zstd_compress.c
contrib/python-zstandard/zstd/compress/zstd_opt.h
contrib/python-zstandard/zstd/compress/zstdmt_compress.c
contrib/python-zstandard/zstd/compress/zstdmt_compress.h
contrib/python-zstandard/zstd/decompress/huf_decompress.c
contrib/python-zstandard/zstd/decompress/zstd_decompress.c
contrib/python-zstandard/zstd/dictBuilder/cover.c
contrib/python-zstandard/zstd/dictBuilder/divsufsort.c
contrib/python-zstandard/zstd/dictBuilder/divsufsort.h
contrib/python-zstandard/zstd/dictBuilder/zdict.c
contrib/python-zstandard/zstd/dictBuilder/zdict.h
contrib/python-zstandard/zstd/zstd.h
hgext/fsmonitor/pywatchman/bser.c

tests/test-check-clang-format.t

  • This file was added.
#require clang-format test-repo
ryanmceUnsubmitted
Not Done

This test fails for me with errors about lz4revlog.

It feels like what we need here is a change similar to 6c113a7dec52, where we use the system hg to examine the local repository. Please reuse the syshg function here.

ryanmce: This test fails for me with errors about lz4revlog. It feels like what we need here is a…
durin42AuthorUnsubmitted
Not Done

Derp, this is done.

durin42: Derp, this is done.
$ . "$TESTDIR/helpers-testrepo.sh"
$ cd "$TESTDIR"/..
$ for f in `testrepohg files 'set:(**.c or **.h) and not "listfile:contrib/clang-format-blacklist"'` ; do
> clang-format --style file $f > $f.formatted
> cmp $f $f.formatted || diff -u $f $f.formatted
> rm $f.formatted
> done