This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1132

mpatch: switch alignment of wrapped line from tab to spaces with clang-format
ClosedPublic

Authored by durin42 on Oct 16 2017, 9:53 PM.

Details

Reviewers
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG1f4249c764f1: mpatch: switch alignment of wrapped line from tab to spaces with clang-format
Summary

I may be a weird person for liking this style, but our C style is
historically nominally the Linux Kernel style, and when you configure
clang-format to be kernel-ish, this is what you get. If we want to
change it, we can do so by tweaking the formatter rules in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 9:53 PM
ryanmce accepted this revision.Oct 17 2017, 7:44 AM
ryanmce added a subscriber: ryanmce.

queued

This revision is now accepted and ready to land.Oct 17 2017, 7:44 AM
Closed by commit rHG1f4249c764f1: mpatch: switch alignment of wrapped line from tab to spaces with clang-format (authored by durin42). · Explain WhyOct 17 2017, 7:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/mpatch.c (2 lines)

Diff 2897

mercurial/mpatch.c

if (start + 1 == end) { if (start + 1 == end) {
/* trivial case, output a decoded list */ /* trivial case, output a decoded list */
return get_next_item(bins, start); return get_next_item(bins, start);
} }
/* divide and conquer, memory management is elsewhere */ /* divide and conquer, memory management is elsewhere */
len = (end - start) / 2; len = (end - start) / 2;
return combine(mpatch_fold(bins, get_next_item, start, start + len), return combine(mpatch_fold(bins, get_next_item, start, start + len),
mpatch_fold(bins, get_next_item, start + len, end)); mpatch_fold(bins, get_next_item, start + len, end));
} }