Page MenuHomePhabricator

webutil: use pycompat.bytestr() instead of str()
ClosedPublic

Authored by durin42 on Oct 16 2017, 10:56 PM.

Details

Summary

Stops us from choking the templater on Python 3. With this patch
applied, much of hgweb works correctly in Python 3. The notable
exception is the graph page, which chokes because it gets node IDs as
str instead of bytes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 10:56 PM
pulkit accepted this revision.Oct 17 2017, 6:42 AM
ryanmce added inline comments.
mercurial/hgweb/webutil.py
593–597

Buhhhhh, this looks ugly as sin. Can we drop 'name' to the next line please? (I can do that in-flight, actually)

ryanmce accepted this revision.Oct 17 2017, 8:39 AM

queued

This revision is now accepted and ready to land.Oct 17 2017, 8:39 AM
This revision was automatically updated to reflect the committed changes.