Page MenuHomePhabricator

templater: don't blow up when trying to build an abort message
ClosedPublic

Authored by durin42 on Oct 16 2017, 10:56 PM.

Details

Summary

name is unicode, but we need bytes. For now, we'll make the
(mostly-safe) assumption that template filter names will be ascii.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 10:56 PM
ryanmce accepted this revision.Oct 17 2017, 8:39 AM
ryanmce added a subscriber: ryanmce.

queued

This revision is now accepted and ready to land.Oct 17 2017, 8:39 AM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Oct 17 2017, 8:56 AM

pycompat.sysbytes() can be used here.