Page MenuHomePhabricator

rust: Rename get_node methods to data_for_node, get_rev to data_for_rev
ClosedPublic

Authored by SimonSapin on Tue, Sep 14, 12:45 PM.

Details

Summary

These are respective methods of Changelog, Manifestlog, and Filelog;
three Rust structs that that wrap a Revlog struct.

This rename clarifies that node IDs or revision numbers are parameters,
not return values.

Also reword doc-comments in Manifestlog and Filelog to separate node IDs
and revision numbers that are local to a given (non-changelog) revlog
from those of a changeset.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Tue, Sep 14, 12:45 PM
Alphare accepted this revision.Wed, Sep 15, 3:48 AM
This revision is now accepted and ready to land.Wed, Sep 15, 3:48 AM