( )⚙ D11470 util: avoid a name-error warning in the `mmapread` exception handler

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11470

util: avoid a name-error warning in the `mmapread` exception handler
ClosedPublic

Authored by mharbison72 on Sep 21 2021, 11:38 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGae79611e3115: util: avoid a name-error warning in the `mmapread` exception handler
Summary

Newly caught by pytype 2021-09-09.

File "/mnt/c/Users/Matt/hg/mercurial/util.py", line 458, in mmapread: Name 'fd' is not defined [name-error]

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)

Diff 30344

mercurial/util.py

def mmapread(fp, size=None): def mmapread(fp, size=None):
if size == 0: if size == 0:
# size of 0 to mmap.mmap() means "all data" # size of 0 to mmap.mmap() means "all data"
# rather than "zero bytes", so special case that. # rather than "zero bytes", so special case that.
return b'' return b''
elif size is None: elif size is None:
size = 0 size = 0
try:
fd = getattr(fp, 'fileno', lambda: fp)() fd = getattr(fp, 'fileno', lambda: fp)()
try:
return mmap.mmap(fd, size, access=mmap.ACCESS_READ) return mmap.mmap(fd, size, access=mmap.ACCESS_READ)
except ValueError: except ValueError:
# Empty files cannot be mmapped, but mmapread should still work. Check # Empty files cannot be mmapped, but mmapread should still work. Check
# if the file is empty, and if so, return an empty buffer. # if the file is empty, and if so, return an empty buffer.
if os.fstat(fd).st_size == 0: if os.fstat(fd).st_size == 0:
return b'' return b''
raise raise