( )⚙ D11476 extensions: prevent a crash on py3 with a `minimumhgversion` str value

This is an archive of the discontinued Mercurial Phabricator instance.

extensions: prevent a crash on py3 with a `minimumhgversion` str value
ClosedPublic

Authored by mharbison72 on Sep 21 2021, 11:39 AM.

Details

Summary

The expectation is that this field is bytes, but unported extensions are a thing
and it shouldn't explode on a bad value. We already do this transformation in
the version reporting mechanism.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Sep 21 2021, 11:39 AM
Alphare accepted this revision.Sep 22 2021, 3:53 AM
This revision is now accepted and ready to land.Sep 22 2021, 3:53 AM