( )⚙ D11522 dirstate: add a `get_entry` method to the dirstate

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11522

dirstate: add a `get_entry` method to the dirstate
ClosedPublic

Authored by marmoute on Oct 1 2021, 5:38 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG6a78715e56c8: dirstate: add a `get_entry` method to the dirstate
Summary

This method give access to the underlying DirstateEntry object (or an empty
one if None was there). It should allow us to use the more semantic property of
the entry instead of the state where we needs it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 1 2021, 5:38 AM
Alphare accepted this revision.Oct 1 2021, 11:13 AM
This revision is now accepted and ready to land.Oct 1 2021, 11:13 AM
marmoute added a commit: rHG6a78715e56c8: dirstate: add a `get_entry` method to the dirstate.Oct 1 2021, 4:44 PM
Closed by commit rHG6a78715e56c8: dirstate: add a `get_entry` method to the dirstate (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (7 lines)

Diff 30522

mercurial/dirstate.py

consider migrating all user of this to going through the dirstate entry consider migrating all user of this to going through the dirstate entry
instead. instead.
""" """
entry = self._map.get(key) entry = self._map.get(key)
if entry is not None: if entry is not None:
return entry.state return entry.state
return b'?' return b'?'
def get_entry(self, path):
"""return a DirstateItem for the associated path"""
entry = self._map.get(path)
if entry is None:
return DirstateItem()
return entry
def __contains__(self, key): def __contains__(self, key):
return key in self._map return key in self._map
def __iter__(self): def __iter__(self):
return iter(sorted(self._map)) return iter(sorted(self._map))
def items(self): def items(self):
return pycompat.iteritems(self._map) return pycompat.iteritems(self._map)