This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-item: introduce a `maybe_clean` property
ClosedPublic

Authored by marmoute on Oct 1 2021, 5:38 AM.

Details

Summary

It is useful for some extension that seek to invalidate some state.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 1 2021, 5:38 AM
Alphare accepted this revision.Oct 1 2021, 11:17 AM
This revision is now accepted and ready to land.Oct 1 2021, 11:17 AM

On second thought, the semantics of this is not obvious from the docstring. Maybe updating it with some examples could make it more obvious.

Alphare requested changes to this revision.Oct 1 2021, 11:26 AM
This revision now requires changes to proceed.Oct 1 2021, 11:26 AM
marmoute requested review of this revision.Oct 1 2021, 11:31 AM

On second thought, the semantics of this is not obvious from the docstring. Maybe updating it with some examples could make it more obvious.

I can follow up with clarification later if that is fine by you.

Alphare accepted this revision.Oct 1 2021, 11:31 AM

Sure, that makes for less churn.

This revision is now accepted and ready to land.Oct 1 2021, 11:31 AM
This revision was automatically updated to reflect the committed changes.