( )⚙ D11672 path: unify path creation in `get_pull_paths`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11672

path: unify path creation in `get_pull_paths`
ClosedPublic

Authored by marmoute on Oct 15 2021, 4:18 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG08630dd719f9: path: unify path creation in `get_pull_paths`
Summary

This remove a special case and will make it possible to return path instance
directly.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 15 2021, 4:18 AM
pulkit accepted this revision.Oct 15 2021, 8:51 AM
This revision is now accepted and ready to land.Oct 15 2021, 8:51 AM
Alphare accepted this revision.Oct 18 2021, 5:53 AM
marmoute updated this revision to Diff 30856.Oct 18 2021, 6:02 AM
marmoute updated this revision to Diff 30862.Oct 18 2021, 6:20 AM
marmoute added a commit: rHG08630dd719f9: path: unify path creation in `get_pull_paths`.Oct 18 2021, 7:53 AM
Closed by commit rHG08630dd719f9: path: unify path creation in `get_pull_paths` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/urlutil.py (9 lines)

Diff 30870

mercurial/utils/urlutil.py

"""yields all the `(path, branch)` selected as pull source by `sources`""" """yields all the `(path, branch)` selected as pull source by `sources`"""
if not sources: if not sources:
sources = [b'default'] sources = [b'default']
for source in sources: for source in sources:
if source in ui.paths: if source in ui.paths:
for p in ui.paths[source]: for p in ui.paths[source]:
yield parseurl(p.rawloc, default_branches) yield parseurl(p.rawloc, default_branches)
else: else:
# Try to resolve as a local path or URI. p = path(ui, None, source, validate_path=False)
path = try_path(ui, source) yield parseurl(p.rawloc, default_branches)
if path is not None:
url = path.rawloc
else:
url = source
yield parseurl(url, default_branches)
def get_unique_push_path(action, repo, ui, dest=None): def get_unique_push_path(action, repo, ui, dest=None):
"""return a unique `path` or abort if multiple are found """return a unique `path` or abort if multiple are found
This is useful for command and action that does not support multiple This is useful for command and action that does not support multiple
destination (yet). destination (yet).