Details
Details
- Reviewers
mjpieters durham - Group Reviewers
Restricted Project - Commits
- rFBHGX7698bb9a21d8: fold: use context manager for locks and transaction
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
hgext3rd/fbamend/fold.py | ||
---|---|---|
110–111 | This swaps the order of the transaction being entered and the foldcheck being done. I suspect this order matters. Creating a transaction is certainly quite involved, if the foldcheck fails we can avoid all that cost. Please add a separate with repo.transaction('fold') as tr: after the _foldcheck(...) line. |
hgext3rd/fbamend/fold.py | ||
---|---|---|
110–111 |
This swaps the order of the transaction being entered and the foldcheck being done. I suspect this order matters. Creating a transaction is certainly quite involved, if the foldcheck fails we can avoid all that cost.
Please add a separate with repo.transaction('fold') as tr: after the _foldcheck(...) line.