Page MenuHomePhabricator

backout: backout 5d83a40cd3f8 and re-instate Python 2 support
ClosedPublic

Authored by Alphare on Nov 15 2021, 12:07 PM.

Details

Summary

...sigh

We do not have Python 3 packaging for thg on Windows where the vast majority of
of users use the thg installer for Mercurial. Until this is done (hopefully
this cycle), we're keeping Python 2.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Nov 15 2021, 12:07 PM

Until this is done (hopefully this cycle), we're keeping Python 2.

To make sure I understand correctly, "this cycle" here refers to the cycle *after* 6.0? So we're instead hoping that 6.1 will be the last release with support for Python 2?

Until this is done (hopefully this cycle), we're keeping Python 2.

To make sure I understand correctly, "this cycle" here refers to the cycle *after* 6.0? So we're instead hoping that 6.1 will be the last release with support for Python 2?

This patch basically mean that if we fix thg packaging before 6.1 is released, we can drop Python 2. For us developers, that means still supporting Python 2 until this is done. Could be tomorrow (fingers crossed heh), at the end of the cycle, or in Mercurial 7.8 if nothing moves on. As said previously we're trying to make that work currently internally at Octobus, but it's really not something that we have time (or really expertise) for right now unfortunately.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

Until this is done (hopefully this cycle), we're keeping Python 2.

To make sure I understand correctly, "this cycle" here refers to the cycle *after* 6.0? So we're instead hoping that 6.1 will be the last release with support for Python 2?

This patch basically mean that if we fix thg packaging before 6.1 is released, we can drop Python 2. For us developers, that means still supporting Python 2 until this is done. Could be tomorrow (fingers crossed heh), at the end of the cycle, or in Mercurial 7.8 if nothing moves on. As said previously we're trying to make that work currently internally at Octobus, but it's really not something that we have time (or really expertise) for right now unfortunately.

I'm not comfortable with this state of affairs, and would like the removal of Python 2 to be reinstated: at this point it's been over a year of hopeful yearning that someone will fix tortoisehg, and at this point I think we need to let it break. It's nice having the GUI, and I hope someone picks it up, but I'm not willing to have hg tied to supporting Python 2 forever on the off chance that someone will modernize tortoisehg some day.

First, sorry for the noise I caused, I accidentally pushed this change to hg-committed (which was a problem in itself), which triggered a "bug" (arguably a feature) in the landing process. I pruned my change and I can re-submit it later.

I'm not comfortable with this state of affairs, and would like the removal of Python 2 to be reinstated: at this point it's been over a year of hopeful yearning that someone will fix tortoisehg, and at this point I think we need to let it break. It's nice having the GUI, and I hope someone picks it up, but I'm not willing to have hg tied to supporting Python 2 forever on the off chance that someone will modernize tortoisehg some day.

I completely understand your point. In fact I share the same opinion, but what changed my mind is the pretty solid lead we have to have this fixed by competent people before the end of the 6.1 cycle. Knowing this, I'm more inclined to wait on this concrete thing that the previous yearning as you put it.

I think thg is quite important to the ecosystem and especially for Windows users, we would probably be dropping a lot of them.