This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1187

registrar: move "constant" possiblecmdtypes to class level
ClosedPublic

Authored by martinvonz on Oct 19 2017, 1:22 AM.

Details

Reviewers
quark
lothiraldan
durin42
Group Reviewers
hg-reviewers
Commits
rHG7b857c5947ec: registrar: move "constant" possiblecmdtypes to class level
rHG3ade6ca6e3ed: registrar: move "constant" possiblecmdtypes to class level
Summary

While at it, switch to set literal syntax.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 19 2017, 1:22 AM
quark accepted this revision.Oct 19 2017, 2:22 AM
lothiraldan requested changes to this revision.Oct 19 2017, 2:48 AM
lothiraldan added a subscriber: lothiraldan.

Typo in the commit message swithc

This revision now requires changes to proceed.Oct 19 2017, 2:48 AM
martinvonz edited the summary of this revision. (Show Details)Oct 19 2017, 2:56 AM
martinvonz added a comment.Oct 19 2017, 2:57 AM
In D1187#20013, @lothiraldan wrote:

Typo in the commit message swithc

Done

lothiraldan accepted this revision.Oct 19 2017, 3:41 AM

Looks good to me now

durin42 accepted this revision.Oct 19 2017, 10:56 AM
This revision is now accepted and ready to land.Oct 19 2017, 10:56 AM
Closed by commit rHG3ade6ca6e3ed: registrar: move "constant" possiblecmdtypes to class level (authored by martinvonz). · Explain WhyOct 19 2017, 11:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/registrar.py (6 lines)

Diff 3033

mercurial/registrar.py

recoverablewrite is for write commands which can be recovered like commit. recoverablewrite is for write commands which can be recovered like commit.
readonly is for commands which are read only. readonly is for commands which are read only.
""" """
unrecoverablewrite = "unrecoverable" unrecoverablewrite = "unrecoverable"
recoverablewrite = "recoverable" recoverablewrite = "recoverable"
readonly = "readonly" readonly = "readonly"
possiblecmdtypes = {unrecoverablewrite, recoverablewrite, readonly}
def _doregister(self, func, name, options=(), synopsis=None, def _doregister(self, func, name, options=(), synopsis=None,
norepo=False, optionalrepo=False, inferrepo=False, norepo=False, optionalrepo=False, inferrepo=False,
cmdtype=unrecoverablewrite): cmdtype=unrecoverablewrite):
possiblecmdtypes = set([self.unrecoverablewrite, self.recoverablewrite, if cmdtype not in self.possiblecmdtypes:
self.readonly])
if cmdtype not in possiblecmdtypes:
raise error.ProgrammingError(_("unknown cmdtype value '%s' for " raise error.ProgrammingError(_("unknown cmdtype value '%s' for "
"'%s' command") % (cmdtype, name)) "'%s' command") % (cmdtype, name))
func.norepo = norepo func.norepo = norepo
func.optionalrepo = optionalrepo func.optionalrepo = optionalrepo
func.inferrepo = inferrepo func.inferrepo = inferrepo
func.cmdtype = cmdtype func.cmdtype = cmdtype
if synopsis: if synopsis:
self._table[name] = func, list(options), synopsis self._table[name] = func, list(options), synopsis