Page MenuHomePhabricator

obsfate: makes successorsetverb takes the markers as argument
ClosedPublic

Authored by lothiraldan on Oct 19 2017, 7:41 AM.

Details

Summary

Right now, successorsetverb only needs successors to compute the verb. But we
will want use additional information (effect-flags and operation) in the near
future to compute a better verb.

Add the markers parameter now so extensions (like Evolve) could wrap the
function and start experimenting around better obsfate verbs.

As successorsetverb now takes both successorset and markers parameters, rename
it to obsfateverb, successorsetandmarkersverb was too long.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Oct 19 2017, 7:41 AM
krbullock requested changes to this revision.Oct 19 2017, 3:23 PM
krbullock added a subscriber: krbullock.
krbullock added inline comments.
mercurial/templater.py
1011

Needs an update to the @templatefunc(...) decoration above too.

This revision now requires changes to proceed.Oct 19 2017, 3:23 PM
lothiraldan marked an inline comment as done.Oct 19 2017, 5:00 PM
lothiraldan updated this revision to Diff 3042.
lothiraldan added inline comments.Oct 19 2017, 5:00 PM
mercurial/templater.py
1011

Done

Deferring this until after 4.4, because the added markers argument isn't used yet.

yuja accepted this revision.Nov 9 2017, 8:35 AM
This revision was automatically updated to reflect the committed changes.