This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11926

pytype: stop excluding chgserver.py
ClosedPublic

Authored by mharbison72 on Dec 15 2021, 3:47 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG7caaefa48794: pytype: stop excluding chgserver.py
Summary

This teaches pytype about some lazy initialization, and avoids the following:

File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 666, in _checkextensions:
    No attribute '_hashstate' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 672, in _checkextensions:
    No attribute '_hashstate' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 677, in _bind:
    No attribute '_realaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 683, in _bind:
    No attribute '_realaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 686, in _createsymlink:
    No attribute '_baseaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 686, in _createsymlink:
    No attribute '_realaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 688, in _createsymlink:
    No attribute '_baseaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 689, in _createsymlink:
    No attribute '_realaddress' on chgunixservicehandler [attribute-error]
File "/mnt/c/Users/Matt/hg/mercurial/chgserver.py", line 690, in _createsymlink:
    No attribute '_baseaddress' on chgunixservicehandler [attribute-error]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2021, 3:47 PM
Alphare accepted this revision.Dec 17 2021, 5:57 AM
This revision is now accepted and ready to land.Dec 17 2021, 5:57 AM
mharbison72 added a commit: rHG7caaefa48794: pytype: stop excluding chgserver.py.Dec 17 2021, 6:11 AM
Closed by commit rHG7caaefa48794: pytype: stop excluding chgserver.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/chgserver.py (7 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 31519

mercurial/chgserver.py

class chgunixservicehandler(object): class chgunixservicehandler(object):
"""Set of operations for chg services""" """Set of operations for chg services"""
pollinterval = 1 # [sec] pollinterval = 1 # [sec]
def __init__(self, ui): def __init__(self, ui):
self.ui = ui self.ui = ui
# TODO: use PEP 526 syntax (`_hashstate: hashstate` at the class level)
# when 3.5 support is dropped.
self._hashstate = None # type: hashstate
self._baseaddress = None # type: bytes
self._realaddress = None # type: bytes
self._idletimeout = ui.configint(b'chgserver', b'idletimeout') self._idletimeout = ui.configint(b'chgserver', b'idletimeout')
self._lastactive = time.time() self._lastactive = time.time()
def bindsocket(self, sock, address): def bindsocket(self, sock, address):
self._inithashstate(address) self._inithashstate(address)
self._checkextensions() self._checkextensions()
self._bind(sock) self._bind(sock)
self._createsymlink() self._createsymlink()

tests/test-check-pytype.t

#require pytype py3 slow #require pytype py3 slow
$ cd $RUNTESTDIR/.. $ cd $RUNTESTDIR/..
Many of the individual files that are excluded here confuse pytype Many of the individual files that are excluded here confuse pytype
because they do a mix of Python 2 and Python 3 things because they do a mix of Python 2 and Python 3 things
conditionally. There's no good way to help it out with that as far as conditionally. There's no good way to help it out with that as far as
I can tell, so let's just hide those files from it for now. We should I can tell, so let's just hide those files from it for now. We should
endeavor to empty this list out over time, as some of these are endeavor to empty this list out over time, as some of these are
probably hiding real problems. probably hiding real problems.
mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo
mercurial/chgserver.py # [attribute-error]
mercurial/context.py # many [attribute-error] mercurial/context.py # many [attribute-error]
mercurial/crecord.py # tons of [attribute-error], [module-attr] mercurial/crecord.py # tons of [attribute-error], [module-attr]
mercurial/debugcommands.py # [wrong-arg-types] mercurial/debugcommands.py # [wrong-arg-types]
mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error] mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error]
mercurial/exchange.py # [attribute-error] mercurial/exchange.py # [attribute-error]
mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types] mercurial/hgweb/hgweb_mod.py # [attribute-error], [name-error], [wrong-arg-types]
mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr] mercurial/hgweb/server.py # [attribute-error], [name-error], [module-attr]
mercurial/hgweb/wsgicgi.py # confused values in os.environ mercurial/hgweb/wsgicgi.py # confused values in os.environ
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
TODO: use --no-cache on test server? Caching the files locally helps during TODO: use --no-cache on test server? Caching the files locally helps during
development, but may be a hinderance for CI testing. development, but may be a hinderance for CI testing.
$ pytype -V 3.6 --keep-going --jobs auto mercurial \ $ pytype -V 3.6 --keep-going --jobs auto mercurial \
> -x mercurial/bundlerepo.py \ > -x mercurial/bundlerepo.py \
> -x mercurial/chgserver.py \
> -x mercurial/context.py \ > -x mercurial/context.py \
> -x mercurial/crecord.py \ > -x mercurial/crecord.py \
> -x mercurial/debugcommands.py \ > -x mercurial/debugcommands.py \
> -x mercurial/dispatch.py \ > -x mercurial/dispatch.py \
> -x mercurial/exchange.py \ > -x mercurial/exchange.py \
> -x mercurial/hgweb/hgweb_mod.py \ > -x mercurial/hgweb/hgweb_mod.py \
> -x mercurial/hgweb/server.py \ > -x mercurial/hgweb/server.py \
> -x mercurial/hgweb/wsgicgi.py \ > -x mercurial/hgweb/wsgicgi.py \